cleanup tests

Author: pcrespov

services/api-server/tests/unit/test_api_solver_jobs.py

@@ -40,7 +40,7 @@ def _start_job_side_effect(
     return capture.response_body
 
 
-def get_inspect_job_side_effect(job_id: str) -> SideEffectCallback:
+def _get_inspect_job_side_effect(job_id: str) -> SideEffectCallback:
     def _inspect_job_side_effect(
         request: httpx.Request,
         path_params: dict[str, Any],
@@ -250,7 +250,7 @@ def _put_pricing_plan_and_unit_side_effect(
         _start_job_side_effect,
     ]
     if expected_status_code == status.HTTP_202_ACCEPTED:
-        callbacks.append(get_inspect_job_side_effect(job_id=_job_id))
+        callbacks.append(_get_inspect_job_side_effect(job_id=_job_id))
 
     _put_pricing_plan_and_unit_side_effect.was_called = False
     create_respx_mock_from_capture(
@@ -296,7 +296,7 @@ async def test_get_solver_job_pricing_unit_no_payment(
         capture_path=project_tests_dir / "mocks" / "start_job_no_payment.json",
         side_effects_callbacks=[
             _start_job_side_effect,
-            get_inspect_job_side_effect(job_id=_job_id),
+            _get_inspect_job_side_effect(job_id=_job_id),
         ],
     )
 
@@ -329,7 +329,7 @@ async def test_start_solver_job_conflict(
         capture_path=project_tests_dir / "mocks" / "start_solver_job.json",
         side_effects_callbacks=[
             _start_job_side_effect,
-            get_inspect_job_side_effect(job_id=_job_id),
+            _get_inspect_job_side_effect(job_id=_job_id),
         ],
     )
 
@@ -370,7 +370,7 @@ def _stop_job_side_effect(
         capture_path=project_tests_dir / "mocks" / "stop_job.json",
         side_effects_callbacks=[
             _stop_job_side_effect,
-            get_inspect_job_side_effect(job_id=_job_id),
+            _get_inspect_job_side_effect(job_id=_job_id),
         ],
     )
 

services/api-server/tests/unit/test_api_solvers.py

@@ -7,9 +7,11 @@
 
 import httpx
 import pytest
+import respx
 from fastapi import status
 from httpx import AsyncClient
 from models_library.api_schemas_api_server.pricing_plans import ServicePricingPlanGet
+from pytest_mock import MockType
 from pytest_simcore.helpers.httpx_calls_capture_models import CreateRespxMockCallback
 from simcore_service_api_server._meta import API_VTAG
 
@@ -26,7 +28,7 @@
 )
 async def test_get_solver_pricing_plan(
     client: AsyncClient,
-    mocked_webserver_rest_api_base,
+    mocked_webserver_rest_api_base: respx.MockRouter,
     create_respx_mock_from_capture: CreateRespxMockCallback,
     auth: httpx.BasicAuth,
     project_tests_dir: Path,
@@ -60,7 +62,7 @@ async def test_get_solver_pricing_plan(
 )
 async def test_get_latest_solver_release(
     client: AsyncClient,
-    mocked_catalog_rpc_api,
+    mocked_catalog_rpc_api: dict[str, MockType],
     auth: httpx.BasicAuth,
     solver_key: str,
     expected_status_code: int,