Skip to content

Commit a9befe4

Browse files
author
Andrei Neagu
committed
renamed cancellation to remove_task
1 parent fd1cae6 commit a9befe4

File tree

15 files changed

+19
-21
lines changed

15 files changed

+19
-21
lines changed

api/specs/web-server/_long_running_tasks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ def get_async_job_status(
5353

5454
@router.delete(
5555
"/tasks/{task_id}",
56-
name="cancel_and_delete_task",
57-
description="Cancels and deletes a task",
56+
name="remove_task",
57+
description="Cancels and removes a task",
5858
responses=_export_data_responses,
5959
status_code=status.HTTP_204_NO_CONTENT,
6060
)

api/specs/web-server/_long_running_tasks_legacy.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ async def get_task_status(
4242

4343
@router.delete(
4444
"/{task_id}",
45-
name="cancel_and_delete_task",
46-
description="Cancels and deletes a task",
45+
name="remove_task",
46+
description="Cancels and removes a task",
4747
status_code=status.HTTP_204_NO_CONTENT,
4848
)
49-
async def cancel_and_delete_task(
49+
async def remove_task(
5050
_path_params: Annotated[_PathParam, Depends()],
5151
): ...
5252

packages/service-library/src/servicelib/aiohttp/long_running_tasks/_routes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ async def list_tasks(request: web.Request) -> web.Response:
2626
task_id=t.task_id,
2727
status_href=f"{request.app.router['get_task_status'].url_for(task_id=t.task_id)}",
2828
result_href=f"{request.app.router['get_task_result'].url_for(task_id=t.task_id)}",
29-
abort_href=f"{request.app.router['cancel_and_delete_task'].url_for(task_id=t.task_id)}",
29+
abort_href=f"{request.app.router['remove_task'].url_for(task_id=t.task_id)}",
3030
)
3131
for t in await lrt_api.list_tasks(
3232
long_running_manager,

packages/service-library/src/servicelib/aiohttp/long_running_tasks/_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ async def start_long_running_task(
8181
f"http://{ip_addr}:{port}{request_.app.router['get_task_result'].url_for(task_id=task_id)}" # NOSONAR
8282
)
8383
abort_url = TypeAdapter(AnyHttpUrl).validate_python(
84-
f"http://{ip_addr}:{port}{request_.app.router['cancel_and_delete_task'].url_for(task_id=task_id)}" # NOSONAR
84+
f"http://{ip_addr}:{port}{request_.app.router['remove_task'].url_for(task_id=task_id)}" # NOSONAR
8585
)
8686
task_get = TaskGet(
8787
task_id=task_id,

packages/service-library/src/servicelib/fastapi/long_running_tasks/_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ async def get_task_result(
171171
return result.json()
172172

173173
@retry_on_http_errors
174-
async def cancel_and_delete_task(
174+
async def remove_task(
175175
self, task_id: TaskId, *, timeout: PositiveFloat | None = None # noqa: ASYNC109
176176
) -> None:
177177
timeout = timeout or self._client_configuration.default_timeout

packages/service-library/src/servicelib/fastapi/long_running_tasks/_context_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ async def _wait_for_task_result() -> Any:
121121

122122
yield result
123123
except TimeoutError as e:
124-
await client.cancel_and_delete_task(task_id)
124+
await client.remove_task(task_id)
125125
raise TaskClientTimeoutError(
126126
task_id=task_id,
127127
timeout=task_timeout,

packages/service-library/src/servicelib/fastapi/long_running_tasks/_routes.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ async def list_tasks(
2525
task_id=t.task_id,
2626
status_href=str(request.url_for("get_task_status", task_id=t.task_id)),
2727
result_href=str(request.url_for("get_task_result", task_id=t.task_id)),
28-
abort_href=str(
29-
request.url_for("cancel_and_delete_task", task_id=t.task_id)
30-
),
28+
abort_href=str(request.url_for("remove_task", task_id=t.task_id)),
3129
)
3230
for t in await lrt_api.list_tasks(long_running_manager, task_context={})
3331
]

packages/service-library/src/servicelib/long_running_tasks/_rabbit/__init__.py

Whitespace-only changes.

packages/service-library/src/servicelib/long_running_tasks/_rabbit/lrt_clinet.py

Whitespace-only changes.

packages/service-library/src/servicelib/long_running_tasks/_rabbit/lrt_server.py

Whitespace-only changes.

0 commit comments

Comments
 (0)