🐛Director-v0: ensure error are enveloped too (#8081)

Author: sanderegg

services/catalog/src/simcore_service_catalog/clients/director.py

@@ -82,7 +82,9 @@ def _unenvelope_or_raise_error(
         """
         body = resp.json()
 
-        assert "data" in body or "error" in body  # nosec
+        assert (
+            "data" in body or "error" in body
+        ), f"here is the failing {body=}, {resp.request=}"  # nosec
         data = body.get("data")
         error = body.get("error")
 
@@ -250,7 +252,6 @@ async def get_service_extras(
                     # discrete resources (custom made ones) ---
                     # check if the service requires GPU support
                     if not invalid_with_msg and _validate_kind(entry, "VRAM"):
-
                         result["node_requirements"]["GPU"] = 1
                     if not invalid_with_msg and _validate_kind(entry, "MPI"):
                         result["node_requirements"]["MPI"] = 1
@@ -282,7 +283,6 @@ async def get_service_extras(
             for dl, sl in _ORG_LABELS_TO_SCHEMA_LABELS.items()
             if dl in labels
         }:
-
             result.update({"service_build_details": service_build_details})
 
         return TypeAdapter(ServiceExtras).validate_python(result)

services/director/src/simcore_service_director/core/application.py

@@ -4,6 +4,7 @@
 from fastapi import FastAPI
 from servicelib.async_utils import cancel_sequential_workers
 from servicelib.fastapi.client_session import setup_client_session
+from servicelib.fastapi.http_error import set_app_default_http_error_handlers
 from servicelib.fastapi.tracing import (
     initialize_fastapi_app_tracing,
     setup_tracing,
@@ -73,6 +74,7 @@ def create_app(settings: ApplicationSettings) -> FastAPI:
         initialize_fastapi_app_tracing(app)
 
     # ERROR HANDLERS
+    set_app_default_http_error_handlers(app)
 
     # EVENTS
     async def _on_startup() -> None: