Skip to content

Commit ace882f

Browse files
committed
fixing tests
1 parent a0fea3b commit ace882f

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

services/web/server/tests/conftest.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@
1919
from aiohttp.test_utils import TestClient
2020
from common_library.json_serialization import json_dumps
2121
from faker import Faker
22-
from models_library.api_schemas_webserver.projects import ProjectGet
22+
from models_library.api_schemas_webserver.projects import (
23+
ProjectGet,
24+
ProjectStateOutputSchema,
25+
)
2326
from models_library.projects import ProjectID
2427
from models_library.projects_nodes_io import NodeID
2528
from pytest_mock import MockerFixture
@@ -417,10 +420,9 @@ async def _creator(
417420
# now check returned is as expected
418421
if new_project:
419422
# has project state
420-
assert (
421-
new_project.get("state", {}).get("shareState", {}).get("locked", False)
422-
is False
423-
), "Newly created projects should be unlocked"
423+
assert not ProjectStateOutputSchema(
424+
**new_project.get("state", {})
425+
).share_state.locked, "Newly created projects should be unlocked"
424426

425427
# updated fields
426428
assert expected_data["uuid"] != new_project["uuid"]

services/web/server/tests/unit/with_dbs/02/test_projects_crud_handlers.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
from models_library.api_schemas_directorv2.dynamic_services import (
1919
GetProjectInactivityResponse,
2020
)
21+
from models_library.api_schemas_webserver.projects import ProjectStateOutputSchema
2122
from models_library.products import ProductName
22-
from models_library.projects_state import ProjectState
2323
from pydantic import TypeAdapter
2424
from pytest_mock import MockerFixture
2525
from pytest_simcore.helpers.assert_checks import assert_status
@@ -171,7 +171,7 @@ async def _assert_get_same_project(
171171
assert data == {k: project[k] for k in data}
172172

173173
if project_state:
174-
assert ProjectState.model_validate(project_state)
174+
assert ProjectStateOutputSchema.model_validate(project_state)
175175

176176
if project_permalink:
177177
assert ProjectPermalink.model_validate(project_permalink)
@@ -209,7 +209,7 @@ async def test_list_projects(
209209

210210
assert got == {k: template_project[k] for k in got}
211211

212-
assert not ProjectState(
212+
assert not ProjectStateOutputSchema(
213213
**project_state
214214
).share_state.locked, "Templates are not locked"
215215
assert ProjectPermalink.model_validate(project_permalink)
@@ -222,7 +222,7 @@ async def test_list_projects(
222222

223223
assert got == {k: user_project[k] for k in got}
224224

225-
assert ProjectState(**project_state)
225+
assert ProjectStateOutputSchema(**project_state)
226226
assert project_permalink is None
227227
assert folder_id is None
228228

@@ -238,7 +238,7 @@ async def test_list_projects(
238238
folder_id = got.pop("folderId")
239239

240240
assert got == {k: user_project[k] for k in got}
241-
assert not ProjectState(
241+
assert not ProjectStateOutputSchema(
242242
**project_state
243243
).share_state.locked, "Single user does not lock"
244244
assert project_permalink is None
@@ -256,7 +256,7 @@ async def test_list_projects(
256256
folder_id = got.pop("folderId")
257257

258258
assert got == {k: template_project[k] for k in got}
259-
assert not ProjectState(
259+
assert not ProjectStateOutputSchema(
260260
**project_state
261261
).share_state.locked, "Templates are not locked"
262262
assert ProjectPermalink.model_validate(project_permalink)

0 commit comments

Comments
 (0)