Skip to content

Commit ae23ce3

Browse files
authored
🐛[FrontEnd] Better error handling of invalid pre-registration data (#6438)
1 parent ccdeff2 commit ae23ce3

File tree

1 file changed

+25
-6
lines changed

1 file changed

+25
-6
lines changed

services/static-webserver/client/source/class/osparc/po/PreRegistration.js

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ qx.Class.define("osparc.po.PreRegistration", {
2929
break;
3030
case "finding-status":
3131
control = new qx.ui.basic.Label();
32-
this._add(control);
32+
this._add(control, {
33+
rich: true
34+
});
3335
break;
3436
case "pre-registration-container":
3537
control = new qx.ui.container.Scroll();
@@ -76,11 +78,27 @@ qx.Class.define("osparc.po.PreRegistration", {
7678
}
7779
if (form.validate()) {
7880
submitBtn.setFetching(true);
81+
82+
const flashErrorMsg = this.tr("Pre-Registration Failed. See details below");
7983
const findingStatus = this.getChildControl("finding-status");
8084
findingStatus.setValue(this.tr("Searching Pre-Registered users..."));
81-
const params = {
82-
data: JSON.parse(requestAccountData.getValue())
83-
};
85+
86+
let params;
87+
try {
88+
params = {
89+
data: JSON.parse(requestAccountData.getValue())
90+
};
91+
} catch (err) {
92+
console.error(err);
93+
94+
const detailErrorMsg = `Error parsing Request Form JSON. ${err}`;
95+
findingStatus.setValue(detailErrorMsg);
96+
97+
osparc.FlashMessenger.logAs(flashErrorMsg, "ERROR");
98+
submitBtn.setFetching(false);
99+
return
100+
}
101+
84102
osparc.data.Resources.fetch("users", "preRegister", params)
85103
.then(data => {
86104
if (data.length) {
@@ -91,9 +109,10 @@ qx.Class.define("osparc.po.PreRegistration", {
91109
this.__populatePreRegistrationLayout(data);
92110
})
93111
.catch(err => {
94-
findingStatus.setValue(this.tr("Error searching Pre-Registered users"));
112+
const detailErrorMsg = this.tr(`Error during Pre-Registeristration: ${err.message}`)
113+
findingStatus.setValue(detailErrorMsg);
95114
console.error(err);
96-
osparc.FlashMessenger.logAs(err.message, "ERROR");
115+
osparc.FlashMessenger.logAs(flashErrorMsg, "ERROR");
97116
})
98117
.finally(() => submitBtn.setFetching(false));
99118
}

0 commit comments

Comments
 (0)