File tree Expand file tree Collapse file tree 2 files changed +5
-0
lines changed Expand file tree Collapse file tree 2 files changed +5
-0
lines changed Original file line number Diff line number Diff line change @@ -189,6 +189,7 @@ async def launch_instances(
189189                    instance_type = instance_config .type .name ,
190190                    available_ips = total_available_ips ,
191191                )
192+ 
192193            # now let's not try to run instances in subnets that have not enough IPs 
193194            subnet_ids_with_capacity  =  [
194195                subnet_id 
Original file line number Diff line number Diff line change @@ -952,6 +952,10 @@ async def test_launch_instances_raises_ec2_subnets_not_enough_ips_error(
952952    assert  error .available_ips  ==  6   # type: ignore 
953953
954954
955+ @pytest .mark .xfail ( 
956+     reason = "if the user asks for a minimum number of instances that cannot fit a subnet, then it currently raises! "  
957+     "it is currently not required that the instances are distributed among subnets"  
958+ ) 
955959async  def  test_launch_instances_distributes_instances_among_subnets (
956960    simcore_ec2_api : SimcoreEC2API ,
957961    ec2_client : EC2Client ,
    
 
   
 
     
   
   
          
     
  
    
     
 
    
      
     
 
     
    You can’t perform that action at this time.
  
 
    
  
     
    
      
        
     
 
       
      
     
   
 
    
    
  
 
  
 
     
    
0 commit comments