mypy

Author: sanderegg

packages/service-library/src/servicelib/fastapi/http_error.py

@@ -23,7 +23,7 @@
 }
 
 
-TException = TypeVar("TException")
+TException = TypeVar("TException", bound=BaseException)
 
 _logger = logging.getLogger(__name__)
 

services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_tasks/_utils.py

@@ -1,7 +1,7 @@
 import asyncio
 import logging
 from decimal import Decimal
-from typing import Any, Final, cast
+from typing import Any, Final
 
 import arrow
 from dask_task_models_library.container_tasks.protocol import ContainerEnvsDict
@@ -19,7 +19,6 @@
 from models_library.resource_tracker import HardwareInfo
 from models_library.service_settings_labels import (
     SimcoreServiceLabels,
-    SimcoreServiceSettingsLabel,
 )
 from models_library.services import (
     ServiceKey,
@@ -118,7 +117,7 @@ def _compute_node_boot_mode(node_resources: ServiceResourcesDict) -> BootMode:
 
 def _compute_node_envs(node_labels: SimcoreServiceLabels) -> ContainerEnvsDict:
     node_envs = {}
-    for service_setting in cast(SimcoreServiceSettingsLabel, node_labels.settings):
+    for service_setting in node_labels.settings:
         if service_setting.name == "env":
             for complete_env in service_setting.value:
                 parts = complete_env.split("=")

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/settings.py

@@ -1,6 +1,6 @@
 import logging
 from collections import deque
-from typing import Any, cast
+from typing import Any
 
 from common_library.json_serialization import json_dumps, json_loads
 from models_library.basic_types import EnvVarKey, PortInt
@@ -495,9 +495,7 @@ async def merge_settings_before_use(
 
     # merge the settings from the all the involved services
     for compose_spec_key, service_labels in labels_for_involved_services.items():
-        service_settings: SimcoreServiceSettingsLabel = cast(
-            SimcoreServiceSettingsLabel, service_labels.settings
-        )
+        service_settings: SimcoreServiceSettingsLabel = service_labels.settings
         settings.extend(
             # inject compose spec key, used to target container specific services
             _add_compose_destination_containers_to_settings_entries(

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/mounted_fs.py

@@ -162,7 +162,7 @@ async def iter_state_paths_to_docker_volumes(
 def setup_mounted_fs(app: FastAPI) -> MountedVolumes:
     settings: ApplicationSettings = app.state.settings
 
-    app.state.mounted_volumes = MountedVolumes(
+    app.state.mounted_volumes = mounted_volumes = MountedVolumes(
         service_run_id=settings.DY_SIDECAR_RUN_ID,
         node_id=settings.DY_SIDECAR_NODE_ID,
         inputs_path=settings.DY_SIDECAR_PATH_INPUTS,
@@ -174,4 +174,4 @@ def setup_mounted_fs(app: FastAPI) -> MountedVolumes:
         dy_volumes=settings.DYNAMIC_SIDECAR_DY_VOLUMES_MOUNT_DIR,
     )
 
-    return app.state.mounted_volumes
+    return mounted_volumes

services/storage/src/simcore_service_storage/simcore_s3_dsm.py

@@ -7,7 +7,7 @@
 from contextlib import suppress
 from dataclasses import dataclass
 from pathlib import Path
-from typing import Any, Final, cast
+from typing import Any, Final
 
 from aws_library.s3 import (
     CopiedBytesTransferredCallback,
@@ -634,7 +634,7 @@ async def create_file_download_link(
         4. Raises FileAccessRightError if the user does not have access to the file
         """
         directory_file_id = await get_directory_file_id(
-            get_db_engine(self.app), cast(SimcoreS3FileID, file_id)
+            get_db_engine(self.app), file_id
         )
         can = await AccessLayerRepository.instance(
             get_db_engine(self.app)