Skip to content

Commit b079ac5

Browse files
author
Andrei Neagu
committed
added comments
1 parent e2422a7 commit b079ac5

File tree

1 file changed

+12
-3
lines changed
  • packages/service-library/src/servicelib/long_running_tasks

1 file changed

+12
-3
lines changed

packages/service-library/src/servicelib/long_running_tasks/task.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ async def setup(self) -> None:
141141
)
142142
await self.locks_redis_client_sdk.setup()
143143

144+
# stale_tasks_monitor
144145
self._task_stale_tasks_monitor = create_periodic_task(
145146
task=exclusive(
146147
self.locks_redis_client_sdk,
@@ -149,15 +150,17 @@ async def setup(self) -> None:
149150
interval=self.stale_task_check_interval,
150151
task_name=f"{__name__}.{self._stale_tasks_monitor.__name__}",
151152
)
152-
153153
await self._started_event_task_stale_tasks_monitor.wait()
154+
155+
# cancelled_tasks_removal
154156
self._task_cancelled_tasks_removal = create_periodic_task(
155157
task=self._cancelled_tasks_removal,
156158
interval=_CANCEL_TASKS_CHECK_INTERVAL,
157159
task_name=f"{__name__}.{self._cancelled_tasks_removal.__name__}",
158160
)
159161
await self._started_event_task_cancelled_tasks_removal.wait()
160162

163+
# status_update
161164
self._task_status_update = create_periodic_task(
162165
task=self._status_update,
163166
interval=_STATUS_UPDATE_CHECK_INTERNAL,
@@ -166,10 +169,13 @@ async def setup(self) -> None:
166169
await self._started_event_task_status_update.wait()
167170

168171
async def teardown(self) -> None:
172+
# ensure all created tasks are cancelled
169173
for tracked_task in await self._tasks_data.list_tasks_data():
170-
# when closing we do not care about pending errors
171174
await self.remove_task(
172-
tracked_task.task_id, tracked_task.task_context, reraise_errors=False
175+
tracked_task.task_id,
176+
tracked_task.task_context,
177+
# when closing we do not care about pending errors
178+
reraise_errors=False,
173179
)
174180

175181
for task in self._created_tasks.values():
@@ -179,12 +185,15 @@ async def teardown(self) -> None:
179185
)
180186
await cancel_wait_task(task)
181187

188+
# stale_tasks_monitor
182189
if self._task_stale_tasks_monitor:
183190
await cancel_wait_task(self._task_stale_tasks_monitor)
184191

192+
# cancelled_tasks_removal
185193
if self._task_cancelled_tasks_removal:
186194
await cancel_wait_task(self._task_cancelled_tasks_removal)
187195

196+
# status_update
188197
if self._task_status_update:
189198
await cancel_wait_task(self._task_status_update)
190199

0 commit comments

Comments
 (0)