refactor

Author: sanderegg

services/web/server/src/simcore_service_webserver/projects/_projects_service.py

@@ -1406,20 +1406,6 @@ async def _get_node_share_state(
     return NodeShareState(locked=False)
 
 
-async def _safe_retrieve(
-    app: web.Application, node_id: NodeID, port_keys: list[str]
-) -> None:
-    try:
-        await dynamic_scheduler_service.retrieve_inputs(app, node_id, port_keys)
-    except RPCServerError as exc:
-        _logger.warning(
-            "Unable to call :retrieve endpoint on service %s, keys: [%s]: error: [%s]",
-            node_id,
-            port_keys,
-            exc,
-        )
-
-
 async def _trigger_connected_service_retrieve(
     app: web.Application, project: dict, updated_node_uuid: str, changed_keys: list[str]
 ) -> None:
@@ -1460,10 +1446,10 @@ async def _trigger_connected_service_retrieve(
 
     # call /retrieve on the nodes
     update_tasks = [
-        _safe_retrieve(app, NodeID(node), keys)
+        dynamic_scheduler_service.retrieve_inputs(app, NodeID(node), keys)
         for node, keys in nodes_keys_to_update.items()
     ]
-    await logged_gather(*update_tasks)
+    await logged_gather(*update_tasks, reraise=False)
 
 
 async def post_trigger_connected_service_retrieve(

services/web/server/tests/integration/01/notifications/test_rabbitmq_consumers.py

@@ -377,7 +377,7 @@ async def test_progress_non_computational_workflow(
 @pytest.fixture
 async def mocked_dynamic_services_interface(
     mocker: MockerFixture,
-) -> dict[str, mock.Mock]:
+) -> dict[str, mock.MagicMock]:  # pylint: disable=no-member
     mock = {}
 
     for func_name in (