minor

Author: odeimaiz

services/static-webserver/client/source/class/osparc/data/model/Node.js

@@ -483,7 +483,14 @@ qx.Class.define("osparc.data.model.Node", {
       return Object.keys(this.getOutputs()).length;
     },
 
-    populateMetadata: function(metadata) {
+    fetchAndPopulateWithMetadata: function() {
+      this.getService(this.getKey(), this.getVersion())
+        .then(serviceMetadata => {
+          this.populateWithMetadata(serviceMetadata);
+        });
+    },
+
+    populateWithMetadata: function(metadata) {
       this.__metaData = metadata;
       if (metadata) {
         if (metadata.name) {
@@ -514,7 +521,7 @@ qx.Class.define("osparc.data.model.Node", {
         if (nodeData.label) {
           this.setLabel(nodeData.label);
         }
-        this.populateInputOutputData(nodeData);
+        this.__populateInputOutputData(nodeData);
         this.populateStates(nodeData);
         if (nodeData.bootOptions) {
           this.setBootOptions(nodeData.bootOptions);
@@ -540,7 +547,7 @@ qx.Class.define("osparc.data.model.Node", {
       }
     },
 
-    populateInputOutputData: function(nodeData) {
+    __populateInputOutputData: function(nodeData) {
       this.__setInputData(nodeData.inputs);
       this.__setInputUnits(nodeData.inputsUnits);
       if (this.getPropsForm()) {
@@ -1277,7 +1284,7 @@ qx.Class.define("osparc.data.model.Node", {
           key: newMetadata["key"],
           version: newMetadata["version"],
         });
-        this.populateMetadata(newMetadata);
+        this.populateWithMetadata(newMetadata);
         this.populateNodeData();
         this.setLabel(label);
         osparc.node.ParameterEditor.setParameterOutputValue(this, value);
@@ -1297,7 +1304,7 @@ qx.Class.define("osparc.data.model.Node", {
           key: newMetadata["key"],
           version: newMetadata["version"],
         });
-        this.populateMetadata(newMetadata);
+        this.populateWithMetadata(newMetadata);
         this.populateNodeData();
         this.setLabel(label);
         this.__setInputData({

services/static-webserver/client/source/class/osparc/data/model/Workbench.js

@@ -273,9 +273,9 @@ qx.Class.define("osparc.data.model.Workbench", {
       nodeRight.setInputConnected(true);
     },
 
-    __createNode: function(study, metadata, nodeId) {
-      const node = new osparc.data.model.Node(study, metadata["key"], metadata["version"], nodeId);
-      node.populateMetadata(metadata);
+    __createNode: function(metadata, nodeId) {
+      const node = new osparc.data.model.Node(this.getStudy(), metadata["key"], metadata["version"], nodeId);
+      node.populateWithMetadata(metadata);
       if (osparc.utils.Utils.eventDrivenPatch()) {
         node.listenToChanges();
         node.addListener("projectDocumentChanged", e => this.fireDataEvent("projectDocumentChanged", e.getData()), this);
@@ -292,6 +292,10 @@ qx.Class.define("osparc.data.model.Workbench", {
       return node;
     },
 
+    deserializeNode: function() {
+      // OM here
+    },
+
     createUnknownNode: function(nodeId) {
       if (nodeId === undefined) {
         nodeId = osparc.utils.Utils.uuidV4();
@@ -331,7 +335,7 @@ qx.Class.define("osparc.data.model.Workbench", {
         const nodeId = resp["node_id"];
 
         this.fireEvent("restartAutoSaveTimer");
-        const node = this.__createNode(this.getStudy(), metadata, nodeId);
+        const node = this.__createNode(metadata, nodeId);
         node.populateNodeData();
         this.__giveUniqueNameToNode(node, node.getLabel());
         node.checkState();
@@ -747,7 +751,7 @@ qx.Class.define("osparc.data.model.Workbench", {
           for (let i=0; i<nodeIds.length; i++) {
             const metadata = values[i];
             const nodeId = nodeIds[i];
-            this.__createNode(this.getStudy(), metadata, nodeId);
+            this.__createNode(metadata, nodeId);
           }
 
           // Then populate them (this will avoid issues of connecting nodes that might not be created yet)