@GitHK review

Author: sanderegg

services/storage/tests/conftest.py

@@ -147,14 +147,6 @@ def app_environment(
     external_envfile_dict: EnvVarsDict,
 ) -> EnvVarsDict:
     if external_envfile_dict:
-        # TODO: see if this is needed
-        # s3_settings = S3Settings.create_from_envs(**external_envfile_dict)
-        # if s3_settings.S3_ENDPOINT is None:
-        #     monkeypatch.delenv("S3_ENDPOINT")
-        #     s3_settings_dict = s3_settings.model_dump(exclude={"S3_ENDPOINT"})
-        # else:
-        #     s3_settings_dict = s3_settings.model_dump()
-
         delenvs_from_dict(monkeypatch, mock_env_devel_environment, raising=False)
         return setenvs_from_dict(monkeypatch, {**external_envfile_dict})
 

services/storage/tests/fixtures/datcore_adapter.py

@@ -26,7 +26,6 @@ def datcore_adapter_service_mock() -> respx.MockRouter:
         respx_mocker.get(list_datasets_re, name="list_datasets").respond(
             status.HTTP_200_OK
         )
-        # TODO: why?
         respx_mocker.get(datcore_adapter_base_url, name="base_endpoint").respond(
             status.HTTP_200_OK, json={}
         )