typos and notes

Andrei Neagu · Andrei Neagu · commit b3bd6e6fb495 · 2025-02-04T14:44:52.000+01:00
diff --git a/packages/service-library/src/servicelib/fastapi/docker.py b/packages/service-library/src/servicelib/fastapi/docker.py
@@ -65,6 +65,7 @@ async def _(app: FastAPI) -> AsyncIterator[State]:
 
             await wait_till_docker_api_proxy_is_responsive(app)
 
+            # NOTE this has to be inside exit_stack scope
             yield {}
 
     return _
diff --git a/services/docker-api-proxy/tests/integration/conftest.py b/services/docker-api-proxy/tests/integration/conftest.py
@@ -14,7 +14,7 @@
     get_lifespan_remote_docker_client,
     get_remote_docker_client,
 )
-from servicelib.fastapi.lifespan_utils import combine_lfiespan_context_managers
+from servicelib.fastapi.lifespan_utils import combine_lifespans
 from settings_library.application import BaseApplicationSettings
 from settings_library.docker_api_proxy import DockerApiProxysettings
 
@@ -40,7 +40,7 @@ class ApplicationSetting(BaseApplicationSettings):
         ]
 
     app = FastAPI(
-        lifespan=combine_lfiespan_context_managers(
+        lifespan=combine_lifespans(
             get_lifespan_remote_docker_client("DOCKER_API_PROXY")
         )
     )

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`get_lifespan_remote_docker_client,`
`15`	`15`	`get_remote_docker_client,`
`16`	`16`	`)`
`17`		`-from servicelib.fastapi.lifespan_utils import combine_lfiespan_context_managers`
	`17`	`+from servicelib.fastapi.lifespan_utils import combine_lifespans`
`18`	`18`	`from settings_library.application import BaseApplicationSettings`
`19`	`19`	`from settings_library.docker_api_proxy import DockerApiProxysettings`
`20`	`20`
`@@ -40,7 +40,7 @@ class ApplicationSetting(BaseApplicationSettings):`
`40`	`40`	`]`
`41`	`41`
`42`	`42`	`app = FastAPI(`
`43`		`- lifespan=combine_lfiespan_context_managers(`
	`43`	`+ lifespan=combine_lifespans(`
`44`	`44`	`get_lifespan_remote_docker_client("DOCKER_API_PROXY")`
`45`	`45`	`)`
`46`	`46`	`)`