Skip to content

Commit b3cda53

Browse files
committed
@sanderegg review: aiohttp exception multiline
1 parent 8a1a8db commit b3cda53

File tree

2 files changed

+6
-3
lines changed
  • packages/service-library/src/servicelib/aiohttp
  • services/web/server/src/simcore_service_webserver/exporter

2 files changed

+6
-3
lines changed

packages/service-library/src/servicelib/aiohttp/rest_responses.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ def create_http_error(
9292
)
9393

9494
return http_error_cls(
95-
reason=reason,
95+
# Multiline not allowed in HTTP reason
96+
reason=reason.replace("\n", " ") if reason else None,
9697
text=json_dumps(
9798
payload,
9899
),

services/web/server/src/simcore_service_webserver/exporter/utils.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import asyncio
2+
from collections.abc import Callable, Coroutine
23
from pathlib import Path
3-
from typing import Any, Callable, Coroutine
4+
from typing import Any
45

56
from aiohttp.abc import AbstractStreamWriter
67
from aiohttp.typedefs import LooseHeaders
@@ -26,7 +27,8 @@ def __init__(
2627
path=path,
2728
chunk_size=chunk_size,
2829
status=status,
29-
reason=reason,
30+
# Multiline not allowed in HTTP reason
31+
reason=reason.replace("\n", " ") if reason else None,
3032
headers=headers,
3133
)
3234
self.remove_tmp_dir_cb = remove_tmp_dir_cb

0 commit comments

Comments
 (0)