fix url types

Author: giancarloromeo

packages/aws-library/src/aws_library/s3/_client.py

@@ -255,7 +255,7 @@ async def create_single_presigned_download_link(
         bucket: S3BucketName,
         object_key: S3ObjectKey,
         expiration_secs: int,
-    ) -> AnyUrl:
+    ) -> str:
         # NOTE: ensure the bucket/object exists, this will raise if not
         await self._client.head_bucket(Bucket=bucket)
         await self._client.head_object(Bucket=bucket, Key=object_key)
@@ -264,20 +264,20 @@ async def create_single_presigned_download_link(
             Params={"Bucket": bucket, "Key": object_key},
             ExpiresIn=expiration_secs,
         )
-        return AnyUrlLegacyAdapter.validate_python(generated_link)
+        return f"{AnyUrlLegacyAdapter.validate_python(generated_link)}"
 
     @s3_exception_handler(_logger)
     async def create_single_presigned_upload_link(
         self, *, bucket: S3BucketName, object_key: S3ObjectKey, expiration_secs: int
-    ) -> AnyUrl:
+    ) -> str:
         # NOTE: ensure the bucket/object exists, this will raise if not
         await self._client.head_bucket(Bucket=bucket)
         generated_link = await self._client.generate_presigned_url(
             "put_object",
             Params={"Bucket": bucket, "Key": object_key},
             ExpiresIn=expiration_secs,
         )
-        return AnyUrlLegacyAdapter.validate_python(generated_link)
+        return f"{AnyUrlLegacyAdapter.validate_python(generated_link)}"
 
     @s3_exception_handler(_logger)
     async def create_multipart_upload_links(

packages/aws-library/tests/test_s3_client.py

@@ -694,11 +694,11 @@ async def test_create_single_presigned_download_link(
         object_key=with_uploaded_file_on_s3.s3_key,
         expiration_secs=default_expiration_time_seconds,
     )
-    assert isinstance(download_url, AnyUrl)
+    assert download_url
 
     dest_file = tmp_path / faker.file_name()
     async with ClientSession() as session:
-        response = await session.get(str(download_url))
+        response = await session.get(download_url)
         response.raise_for_status()
         with dest_file.open("wb") as fp:
             fp.write(await response.read())
@@ -744,7 +744,7 @@ async def test_create_single_presigned_upload_link(
     create_file_of_size: Callable[[ByteSize], Path],
     default_expiration_time_seconds: int,
     upload_to_presigned_link: Callable[
-        [Path, AnyUrl, S3BucketName, S3ObjectKey], Awaitable[None]
+        [Path, str, S3BucketName, S3ObjectKey], Awaitable[None]
     ],
 ):
     file = create_file_of_size(_BYTE_SIZE_ADAPTER.validate_python("1Mib"))