@sanderegg review: rename error

Author: pcrespov

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/catalog/errors.py

@@ -13,5 +13,5 @@ class CatalogForbiddenError(CatalogApiBaseError):
     msg_template = "Insufficient access rights for {name}"
 
 
-class CatalogServiceError(CatalogApiBaseError):
+class CatalogNotAvailableError(CatalogApiBaseError):
     msg_template = "Catalog service failed unexpectedly"

services/web/server/src/simcore_service_webserver/catalog/_api.py

@@ -26,7 +26,7 @@
 from servicelib.aiohttp.requests_validation import handle_validation_as_http_error
 from servicelib.rabbitmq._errors import RPCServerError
 from servicelib.rabbitmq.rpc_interfaces.catalog import services as catalog_rpc
-from servicelib.rabbitmq.rpc_interfaces.catalog.errors import CatalogServiceError
+from servicelib.rabbitmq.rpc_interfaces.catalog.errors import CatalogNotAvailableError
 from servicelib.rest_constants import RESPONSE_MODEL_POLICY
 
 from ..constants import RQ_PRODUCT_KEY, RQT_USERID_KEY
@@ -128,7 +128,7 @@ async def batch_get_my_services(
             ids=services_ids,
         )
     except RPCServerError as err:
-        raise CatalogServiceError(
+        raise CatalogNotAvailableError(
             user_id=user_id,
             product_name=product_name,
         ) from err

services/web/server/src/simcore_service_webserver/projects/_common/exceptions_handlers.py

@@ -6,7 +6,7 @@
 from servicelib.rabbitmq.rpc_interfaces.catalog.errors import (
     CatalogForbiddenError,
     CatalogItemNotFoundError,
-    CatalogServiceError,
+    CatalogNotAvailableError,
 )
 
 from ...exception_handling import (
@@ -164,7 +164,7 @@
 
 
 _OTHER_ERRORS: ExceptionToHttpErrorMap = {
-    CatalogServiceError: HttpErrorInfo(
+    CatalogNotAvailableError: HttpErrorInfo(
         status.HTTP_503_SERVICE_UNAVAILABLE,
         "This service is currently not available",
     ),