Skip to content

Commit b62fe90

Browse files
committed
rename
1 parent 866f7af commit b62fe90

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

services/api-server/src/simcore_service_api_server/_service_jobs.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,16 @@ async def list_jobs(
6464
# 2. Convert projects to jobs
6565
jobs: list[Job] = []
6666
for project_job in projects_page.data:
67+
68+
# NOTE: this is only valid for jobs created for Solvers or Programs which expect a single node per project!
69+
6770
assert ( # nosec
6871
len(project_job.workbench) == 1
6972
), "Expected only one solver node in workbench"
7073

71-
solver_node = next(iter(project_job.workbench.values()))
74+
one_project_node = next(iter(project_job.workbench.values()))
7275
job_inputs: JobInputs = create_job_inputs_from_node_inputs(
73-
inputs=solver_node.inputs or {}
76+
inputs=one_project_node.inputs or {}
7477
)
7578
assert project_job.job_parent_resource_name # nosec
7679

services/api-server/src/simcore_service_api_server/_service_studies.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,11 @@ async def list_jobs(
5454
pagination_offset: PageOffsetInt | None = None,
5555
pagination_limit: PageLimitInt | None = None,
5656
) -> tuple[list[Job], PageMetaInfoLimitOffset]:
57-
"""Lists all solver jobs for a user with pagination"""
57+
"""Lists all study jobs for a user with pagination
58+
59+
60+
If filter_by_study_id==None then it lists all study-jobs of the user
61+
"""
5862

5963
# 1. Compose job parent resource name prefix
6064
collection_or_resource_ids: list[str] = [

services/api-server/tests/unit/service/test_service_studies.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from simcore_service_api_server.models.schemas.studies import StudyID
1616

1717

18-
async def test_list_jobs_no_study_id(
18+
async def test_list_study_jobs_no_study_id(
1919
mocked_rpc_client: MockType,
2020
study_service: StudyService,
2121
):
@@ -46,7 +46,7 @@ async def test_list_jobs_no_study_id(
4646
assert mocked_rpc_client.request.call_args.kwargs["limit"] == page_meta.limit
4747

4848

49-
async def test_list_jobs_with_study_id(
49+
async def test_list_study_jobs_with_study_id(
5050
mocked_rpc_client: MockType,
5151
study_service: StudyService,
5252
):
@@ -97,7 +97,7 @@ def mock_project(mocker: MockerFixture):
9797
}
9898

9999

100-
async def test_create_job(
100+
async def test_create_study_job(
101101
study_service: StudyService,
102102
job_inputs: JobInputs,
103103
mock_project: dict,
@@ -160,7 +160,7 @@ async def test_create_job(
160160
)
161161

162162

163-
async def test_create_job_with_inputs(
163+
async def test_create_study_job_with_inputs(
164164
study_service: StudyService,
165165
mock_project: dict,
166166
mocker: MockerFixture,

0 commit comments

Comments
 (0)