remove note and fixed for pydantic2

Author: Andrei Neagu

packages/models-library/tests/test_service_settings_labels.py

@@ -9,6 +9,7 @@
 from typing import Any, Final, NamedTuple
 
 import pytest
+from common_library.json_serialization import json_dumps
 from models_library.basic_types import PortInt
 from models_library.osparc_variable_identifier import (
     OsparcVariableIdentifier,
@@ -32,7 +33,6 @@
 from models_library.services_resources import DEFAULT_SINGLE_SERVICE_NAME
 from models_library.utils.string_substitution import TextTemplate
 from pydantic import BaseModel, TypeAdapter, ValidationError
-from pydantic.json import pydantic_encoder
 
 
 class _Parametrization(NamedTuple):
@@ -558,11 +558,6 @@ def test_can_parse_labels_with_osparc_identifiers(
     assert "$" not in service_meta_str
 
 
-def servicelib__json_serialization__json_dumps(obj: Any, **kwargs):
-    # Analogous to 'common_library.json_serialization.json_dumps'
-    return json.dumps(obj, default=pydantic_encoder, **kwargs)
-
-
 def test_resolving_some_service_labels_at_load_time(
     vendor_environments: dict[str, Any], service_labels: dict[str, str]
 ):
@@ -579,9 +574,7 @@ def test_resolving_some_service_labels_at_load_time(
         ("settings", SimcoreServiceSettingsLabel),
     ):
         to_serialize = getattr(service_meta, attribute_name)
-        template = TextTemplate(
-            servicelib__json_serialization__json_dumps(to_serialize)
-        )
+        template = TextTemplate(json_dumps(to_serialize))
         assert template.is_valid()
         resolved_label: str = template.safe_substitute(vendor_environments)
         to_restore = TypeAdapter(pydantic_model).validate_json(resolved_label)

packages/models-library/tests/test_utils_fastapi_encoders.py

@@ -4,36 +4,22 @@
 # pylint: disable=too-many-arguments
 
 import json
-from typing import Any
 from uuid import uuid4
 
-import pytest
+from common_library.json_serialization import json_dumps
 from faker import Faker
 from models_library.utils.fastapi_encoders import servicelib_jsonable_encoder
-from pydantic.json import pydantic_encoder
-
-
-def servicelib__json_serialization__json_dumps(obj: Any, **kwargs):
-    # Analogous to 'common_library.json_serialization.json_dumps'
-    return json.dumps(obj, default=pydantic_encoder, **kwargs)
 
 
 def test_using_uuids_as_keys(faker: Faker):
     uuid_key = uuid4()
 
-    with pytest.raises(TypeError):
-        # IMPORTANT NOTE: we cannot serialize UUID objects as keys.
-        # We have to convert them to strings but then the class information is lost upon deserialization i.e. it is not reversable!
-        # NOTE: This could  potentially be solved using 'orjson' !!
-        #
-        servicelib__json_serialization__json_dumps({uuid_key: "value"}, indent=1)
-
-    # use encoder
+    # uuid keys now serialize without raising to the expected format string
     data = servicelib_jsonable_encoder({uuid_key: "value"})
     assert data == {f"{uuid_key}": "value"}
 
     # serialize w/o raising
-    dumped_data = servicelib__json_serialization__json_dumps(data, indent=1)
+    dumped_data = json_dumps(data, indent=1)
 
     # deserialize w/o raising
     loaded_data = json.loads(dumped_data)