removed crontab

Author: sanderegg

packages/aws-library/src/aws_library/ec2/_models.py

@@ -160,13 +160,6 @@ class EC2InstanceBootSpecific(BaseModel):
             description="a list of docker image/tags to pull on instance cold start",
         ),
     ] = DEFAULT_FACTORY
-    pre_pull_images_cron_interval: Annotated[
-        datetime.timedelta,
-        Field(
-            description="time interval between pulls of images (minimum is 1 minute) "
-            "(default to seconds, or see https://pydantic-docs.helpmanual.io/usage/types/#datetime-types for string formating)",
-        ),
-    ] = datetime.timedelta(minutes=30)
     buffer_count: Annotated[
         NonNegativeInt,
         Field(description="number of buffer EC2s to keep (defaults to 0)"),
@@ -180,7 +173,9 @@ def validate_bash_calls(cls, v):
                 temp_file.writelines(v)
                 temp_file.flush()
                 # NOTE: this will not capture runtime errors, but at least some syntax errors such as invalid quotes
-                sh.bash("-n", temp_file.name)  # pyright: ignore[reportCallIssue]  # sh is untyped, but this call is safe for bash syntax checking
+                sh.bash(
+                    "-n", temp_file.name
+                )  # pyright: ignore[reportCallIssue]  # sh is untyped, but this call is safe for bash syntax checking
         except sh.ErrorReturnCode as exc:
             msg = f"Invalid bash call in custom_boot_scripts: {v}, Error: {exc.stderr}"
             raise ValueError(msg) from exc
@@ -231,7 +226,7 @@ def _update_json_schema_extra(schema: JsonDict) -> None:
                             "simcore/services/dynamic/another-nice-one:2.4.5",
                             "asd",
                         ],
-                        "pre_pull_images_cron_interval": "01:00:00",
+                        "pre_pull_images_cron_interval": "01:00:00",  # retired but kept for tests
                     },
                     {
                         # AMI + pre-pull + buffer count

services/autoscaling/tests/unit/test_utils_cluster_scaling.py

@@ -4,7 +4,6 @@
 # pylint: disable=unused-variable
 # pylint: disable=too-many-arguments
 
-import datetime
 import json
 import re
 from collections.abc import Callable
@@ -145,9 +144,6 @@ async def test_ec2_startup_script_just_ami(
         )
     )
     assert not instance_boot_specific.pre_pull_images
-    assert instance_boot_specific.pre_pull_images_cron_interval == datetime.timedelta(
-        minutes=30
-    )
     startup_script = await ec2_startup_script(instance_boot_specific, app_settings)
     assert len(startup_script.split("&&")) == 1
     assert re.fullmatch(
@@ -216,7 +212,6 @@ async def test_ec2_startup_script_with_pre_pulling(
         )
     )
     assert instance_boot_specific.pre_pull_images
-    assert instance_boot_specific.pre_pull_images_cron_interval
     startup_script = await ec2_startup_script(instance_boot_specific, app_settings)
     assert len(startup_script.split("&&")) == 7
     assert re.fullmatch(
@@ -238,7 +233,6 @@ async def test_ec2_startup_script_with_custom_scripts(
             )
         )
         assert not instance_boot_specific.pre_pull_images
-        assert instance_boot_specific.pre_pull_images_cron_interval
         startup_script = await ec2_startup_script(instance_boot_specific, app_settings)
         assert len(startup_script.split("&&")) == 1 + len(
             ec2_instances_boot_ami_scripts
@@ -262,7 +256,6 @@ async def test_ec2_startup_script_with_pre_pulling_but_no_registry(
         )
     )
     assert instance_boot_specific.pre_pull_images
-    assert instance_boot_specific.pre_pull_images_cron_interval
     startup_script = await ec2_startup_script(instance_boot_specific, app_settings)
     assert len(startup_script.split("&&")) == 1
     assert re.fullmatch(