Skip to content

Commit b8239ca

Browse files
committed
Remove no needed test @sanderegg
1 parent ac301b5 commit b8239ca

File tree

1 file changed

+2
-48
lines changed

1 file changed

+2
-48
lines changed

packages/service-library/tests/aiohttp/test_tracing.py

Lines changed: 2 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -67,51 +67,5 @@ async def test_invalid_tracing_settings(
6767
set_and_clean_settings_env_vars: Callable,
6868
tracing_settings_in,
6969
) -> TestClient:
70-
app = web.Application()
71-
service_name = "simcore_service_webserver"
72-
with pytest.raises((BaseException, TypeError, ValidationError)):
73-
tracing_settings = TracingSettings()
74-
setup_tracing(
75-
app,
76-
service_name=service_name,
77-
tracing_settings=tracing_settings,
78-
)
79-
80-
81-
@pytest.mark.parametrize(
82-
"tracing_settings_in",
83-
[
84-
("", ""),
85-
(None, None),
86-
("", None),
87-
],
88-
indirect=True,
89-
)
90-
async def test_missing_tracing_settings(
91-
aiohttp_client: Callable,
92-
set_and_clean_settings_env_vars: Callable,
93-
tracing_settings_in,
94-
caplog,
95-
) -> TestClient:
96-
app = web.Application()
97-
service_name = "simcore_service_webserver"
98-
# setup_tracing in this case should no nothing
99-
tracing_settings = TracingSettings()
100-
setup_tracing(app, service_name=service_name, tracing_settings=tracing_settings)
101-
102-
103-
@pytest.mark.parametrize(
104-
"tracing_settings_in", # noqa: PT002
105-
[("http://opentelemetry-collector", None), (None, 4318)],
106-
indirect=True,
107-
)
108-
async def test_incomplete_tracing_settings(
109-
aiohttp_client: Callable,
110-
set_and_clean_settings_env_vars: Callable,
111-
tracing_settings_in,
112-
) -> TestClient:
113-
app = web.Application()
114-
service_name = "simcore_service_webserver"
115-
with pytest.raises((BaseException, TypeError, ValidationError)):
116-
tracing_settings = TracingSettings()
117-
setup_tracing(app, service_name=service_name, tracing_settings=tracing_settings)
70+
with pytest.raises(ValidationError):
71+
TracingSettings()

0 commit comments

Comments
 (0)