no magic strings

Author: odeimaiz

services/static-webserver/client/source/class/osparc/dashboard/CardBase.js

@@ -597,7 +597,11 @@ qx.Class.define("osparc.dashboard.CardBase", {
           break;
         }
         case "function":
-          this.setIcon(osparc.data.model.StudyUI.PIPELINE_ICON);
+          if (resourceData["functionClass"] === osparc.data.model.Function.FUNCTION_CLASS.PROJECT) {
+            this.setIcon(osparc.data.model.StudyUI.PIPELINE_ICON);
+          } else {
+            this.setIcon(osparc.dashboard.CardBase.PRODUCT_ICON);
+          }
           break;
       }
     },

services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js

@@ -81,7 +81,7 @@ qx.Class.define("osparc.dashboard.ResourceDetails", {
               this.__resourceModel["resourceType"] = resourceData["resourceType"];
               this.__addPages();
             }
-            if (resourceData["functionClass"] === "PROJECT") {
+            if (resourceData["functionClass"] === osparc.data.model.Function.FUNCTION_CLASS.PROJECT) {
               // this is only required for functions that have a template linked
               osparc.store.Templates.fetchTemplate(resourceData["templateId"])
                 .then(templateData => {
@@ -408,7 +408,7 @@ qx.Class.define("osparc.dashboard.ResourceDetails", {
         return;
       } else if (osparc.utils.Resources.isFunction(this.__resourceData)) {
         this.__addInfoPage();
-        if (this.__resourceModel.getFunctionClass() === "PROJECT") {
+        if (this.__resourceModel.getFunctionClass() === osparc.data.model.Function.FUNCTION_CLASS.PROJECT) {
           this.__addPreviewPage();
         }
         this.fireEvent("pagesAdded");

services/static-webserver/client/source/class/osparc/data/model/Function.js

@@ -59,7 +59,11 @@ qx.Class.define("osparc.data.model.Function", {
     },
 
     functionClass: {
-      check: ["PROJECT", "SOLVER", "PYTHON_CODE"],
+      check: [
+        "PROJECT",     // osparc.data.model.Function.FUNCTION_CLASS.PROJECT
+        "SOLVER",      // osparc.data.model.Function.FUNCTION_CLASS.SOLVER
+        "PYTHON_CODE", // osparc.data.model.Function.FUNCTION_CLASS.PYTHON
+      ],
       nullable: false,
       event: "changeFunctionClass",
       init: null
@@ -142,9 +146,15 @@ qx.Class.define("osparc.data.model.Function", {
   },
 
   statics: {
+    FUNCTION_CLASS: {
+      PROJECT: "PROJECT",
+      SOLVER: "SOLVER",
+      PYTHON_CODE: "PYTHON_CODE"
+    },
+
     getProperties: function() {
       return Object.keys(qx.util.PropertyUtil.getProperties(osparc.data.model.Function));
-    }
+    },
   },
 
   members: {

services/static-webserver/client/source/class/osparc/store/Functions.js

@@ -27,7 +27,7 @@ qx.Class.define("osparc.store.Functions", {
         "projectId": templateData["uuid"],
         "title": name,
         "description": description,
-        "function_class": "PROJECT",
+        "function_class": osparc.data.model.Function.FUNCTION_CLASS.PROJECT,
         "inputSchema": {
           "schema_class": "application/schema+json",
           "schema_content": {