linter

Author: sanderegg

services/dask-sidecar/src/simcore_service_dask_sidecar/utils/files.py

@@ -20,7 +20,7 @@
 from settings_library.s3 import S3Settings
 from yarl import URL
 
-logger = logging.getLogger(__name__)
+_logger = logging.getLogger(__name__)
 
 HTTP_FILE_SYSTEM_SCHEMES: Final = ["http", "https"]
 S3_FILE_SYSTEM_SCHEMES: Final = ["s3", "s3a"]
@@ -208,7 +208,7 @@ async def pull_file_from_remote(
             await log_publishing_cb(
                 f"Uncompressing '{download_dst_path.name}'...", logging.INFO
             )
-            logger.debug(
+            _logger.debug(
                 "%s is a zip file and will be now uncompressed", download_dst_path
             )
             with repro_zipfile.ReproducibleZipFile(download_dst_path, "r") as zip_obj:
@@ -258,7 +258,7 @@ async def _push_file_to_remote(
     log_publishing_cb: LogPublishingCB,
     s3_settings: S3Settings | None,
 ) -> None:
-    logger.debug("Uploading %s to %s...", file_to_upload, dst_url)
+    _logger.debug("Uploading %s to %s...", file_to_upload, dst_url)
     assert dst_url.path  # nosec
 
     storage_kwargs: S3FsSettingsDict | dict[str, Any] = {}
@@ -306,7 +306,7 @@ async def push_file_to_remote(
                 await asyncio.get_event_loop().run_in_executor(
                     None, zfp.write, src_path, src_path.name
                 )
-            logger.debug("%s created.", archive_file_path)
+            _logger.debug("%s created.", archive_file_path)
             assert archive_file_path.exists()  # nosec
             file_to_upload = archive_file_path
             await log_publishing_cb(
@@ -319,7 +319,7 @@ async def push_file_to_remote(
         )
 
         if dst_url.scheme in HTTP_FILE_SYSTEM_SCHEMES:
-            logger.debug("destination is a http presigned link")
+            _logger.debug("destination is a http presigned link")
             await _push_file_to_http_link(file_to_upload, dst_url, log_publishing_cb)
         else:
             await _push_file_to_remote(

services/dask-sidecar/tests/unit/test_utils_files.py

@@ -526,7 +526,9 @@ async def test_log_partial_file_content(
 
     # Case 1: file longer than max_chars
     with caplog.at_level(logging.DEBUG, logger=logger.name):
-        await log_partial_file_content(file_path, logger, logging.DEBUG, max_chars=10)
+        await log_partial_file_content(
+            file_path, logger=logger, log_level=logging.DEBUG, max_chars=10
+        )
     assert any(
         "file content (truncated): abcdefghij..." in record.getMessage()
         for record in caplog.records
@@ -538,7 +540,9 @@ async def test_log_partial_file_content(
     short_file = tmp_path / "short.txt"
     short_file.write_text(short_content)
     with caplog.at_level(logging.DEBUG, logger=logger.name):
-        await log_partial_file_content(short_file, logger, logging.DEBUG, max_chars=10)
+        await log_partial_file_content(
+            short_file, logger=logger, log_level=logging.DEBUG, max_chars=10
+        )
     assert any(
         "file content: short" in record.getMessage() for record in caplog.records
     )
@@ -548,7 +552,7 @@ async def test_log_partial_file_content(
     non_existent = tmp_path / "doesnotexist.txt"
     with caplog.at_level(logging.DEBUG, logger=logger.name):
         await log_partial_file_content(
-            non_existent, logger, logging.DEBUG, max_chars=10
+            non_existent, logger=logger, log_level=logging.DEBUG, max_chars=10
         )
     assert any(
         f"file does not exist: {non_existent}" in record.getMessage()