nodes

Author: pcrespov

services/web/server/src/simcore_service_webserver/projects/_common/exception_handlers.py

@@ -1,6 +1,7 @@
 import logging
 
 from servicelib.aiohttp import status
+from servicelib.rabbitmq.rpc_interfaces.catalog.errors import CatalogForbiddenError
 
 from ...exception_handling import (
     ExceptionToHttpErrorMap,
@@ -9,13 +10,24 @@
     to_exceptions_handlers_map,
 )
 from ...folders.errors import FolderAccessForbiddenError, FolderNotFoundError
+from ...resource_usage.errors import DefaultPricingPlanNotFoundError
+from ...users.exceptions import UserDefaultWalletNotFoundError
+from ...wallets.errors import WalletAccessForbiddenError, WalletNotEnoughCreditsError
 from ...workspaces.errors import WorkspaceAccessForbiddenError, WorkspaceNotFoundError
 from ..exceptions import (
+    ClustersKeeperNotAvailableError,
+    DefaultPricingUnitNotFoundError,
+    NodeNotFoundError,
+    ParentNodeNotFoundError,
     ProjectDeleteError,
     ProjectGroupNotFoundError,
+    ProjectInDebtCanNotChangeWalletError,
     ProjectInvalidRightsError,
+    ProjectInvalidUsageError,
+    ProjectNodeRequiredInputsNotSetError,
     ProjectNotFoundError,
     ProjectOwnerNotFoundInTheProjectAccessRightsError,
+    ProjectStartsTooManyDynamicNodesError,
     WrongTagIdsInQueryError,
 )
 
@@ -33,6 +45,14 @@
         status.HTTP_404_NOT_FOUND,
         "Folder not found: {reason}",
     ),
+    NodeNotFoundError: HttpErrorInfo(
+        status.HTTP_404_NOT_FOUND,
+        "Node '{node_uuid}' not found in project '{project_uuid}'",
+    ),
+    ParentNodeNotFoundError: HttpErrorInfo(
+        status.HTTP_404_NOT_FOUND,
+        "Parent node '{node_uuid}' not found",
+    ),
     ProjectDeleteError: HttpErrorInfo(
         status.HTTP_409_CONFLICT,
         "Failed to complete deletion of '{project_uuid}': {reason}",
@@ -45,6 +65,10 @@
         status.HTTP_403_FORBIDDEN,
         "Do not have sufficient access rights on project {project_uuid} for this action",
     ),
+    ProjectInvalidUsageError: HttpErrorInfo(
+        status.HTTP_422_UNPROCESSABLE_ENTITY,
+        "Invalid usage for project",
+    ),
     ProjectNotFoundError: HttpErrorInfo(
         status.HTTP_404_NOT_FOUND,
         "Project {project_uuid} not found",
@@ -65,8 +89,47 @@
         status.HTTP_400_BAD_REQUEST,
         "Wrong tag IDs in query",
     ),
+    UserDefaultWalletNotFoundError: HttpErrorInfo(
+        status.HTTP_404_NOT_FOUND,
+        "User default wallet not found",
+    ),
+    DefaultPricingPlanNotFoundError: HttpErrorInfo(
+        status.HTTP_404_NOT_FOUND,
+        "Default pricing plan not found",
+    ),
+    DefaultPricingUnitNotFoundError: HttpErrorInfo(
+        status.HTTP_404_NOT_FOUND,
+        "Default pricing unit not found",
+    ),
+    WalletNotEnoughCreditsError: HttpErrorInfo(
+        status.HTTP_402_PAYMENT_REQUIRED,
+        "Wallet does not have enough credits. {reason}",
+    ),
+    ProjectInDebtCanNotChangeWalletError: HttpErrorInfo(
+        status.HTTP_402_PAYMENT_REQUIRED,
+        "Unable to change the credit account linked to the project. The project is embargoed because the last transaction of {debt_amount} resulted in the credit account going negative.",
+    ),
+    ProjectStartsTooManyDynamicNodesError: HttpErrorInfo(
+        status.HTTP_409_CONFLICT,
+        "The maximal amount of concurrently running dynamic services was reached. Please manually stop a service and retry.",
+    ),
+    ClustersKeeperNotAvailableError: HttpErrorInfo(
+        status.HTTP_503_SERVICE_UNAVAILABLE,
+        "Clusters-keeper service is not available",
+    ),
+    ProjectNodeRequiredInputsNotSetError: HttpErrorInfo(
+        status.HTTP_409_CONFLICT,
+        "Project node is required but input is not set",
+    ),
+    CatalogForbiddenError: HttpErrorInfo(
+        status.HTTP_403_FORBIDDEN,
+        "Catalog forbidden: Insufficient access rights for {name}",
+    ),
+    WalletAccessForbiddenError: HttpErrorInfo(
+        status.HTTP_403_FORBIDDEN,
+        "Payment required, but the user lacks access to the project's linked wallet: Wallet access forbidden. {reason}",
+    ),
 }
-
 handle_plugin_requests_exceptions = exception_handling_decorator(
     to_exceptions_handlers_map(_TO_HTTP_ERROR_MAP)
 )

services/web/server/src/simcore_service_webserver/projects/_metadata_handlers.py

@@ -10,7 +10,6 @@
     - Get and Update methods only
 """
 
-import functools
 import logging
 
 from aiohttp import web
@@ -22,50 +21,21 @@
     parse_request_body_as,
     parse_request_path_parameters_as,
 )
-from servicelib.aiohttp.typing_extension import Handler
 from servicelib.logging_utils import log_catch
 
 from .._meta import api_version_prefix
 from ..login.decorators import login_required
 from ..security.decorators import permission_required
 from ..utils_aiohttp import envelope_json_response
 from . import _metadata_api
+from ._common.exception_handlers import handle_plugin_requests_exceptions
 from ._common.models import ProjectPathParams, RequestContext
-from .exceptions import (
-    NodeNotFoundError,
-    ParentNodeNotFoundError,
-    ProjectInvalidRightsError,
-    ProjectInvalidUsageError,
-    ProjectNotFoundError,
-)
 
 routes = web.RouteTableDef()
 
 _logger = logging.getLogger(__name__)
 
 
-def _handle_project_exceptions(handler: Handler):
-    """Transforms project errors -> http errors"""
-
-    @functools.wraps(handler)
-    async def wrapper(request: web.Request) -> web.StreamResponse:
-        try:
-            return await handler(request)
-
-        except (
-            ProjectNotFoundError,
-            NodeNotFoundError,
-            ParentNodeNotFoundError,
-        ) as exc:
-            raise web.HTTPNotFound(reason=f"{exc}") from exc
-        except ProjectInvalidRightsError as exc:
-            raise web.HTTPUnauthorized(reason=f"{exc}") from exc
-        except ProjectInvalidUsageError as exc:
-            raise web.HTTPUnprocessableEntity(reason=f"{exc}") from exc
-
-    return wrapper
-
-
 #
 # projects/*/custom-metadata
 #
@@ -77,7 +47,7 @@ async def wrapper(request: web.Request) -> web.StreamResponse:
 )
 @login_required
 @permission_required("project.read")
-@_handle_project_exceptions
+@handle_plugin_requests_exceptions
 async def get_project_metadata(request: web.Request) -> web.Response:
     req_ctx = RequestContext.model_validate(request)
     path_params = parse_request_path_parameters_as(ProjectPathParams, request)
@@ -97,7 +67,7 @@ async def get_project_metadata(request: web.Request) -> web.Response:
 )
 @login_required
 @permission_required("project.update")
-@_handle_project_exceptions
+@handle_plugin_requests_exceptions
 async def update_project_metadata(request: web.Request) -> web.Response:
     req_ctx = RequestContext.model_validate(request)
     path_params = parse_request_path_parameters_as(ProjectPathParams, request)