Skip to content

Commit bc2c685

Browse files
committed
no need to reload, listen to the socket
1 parent c8206ae commit bc2c685

File tree

1 file changed

+10
-6
lines changed
  • services/static-webserver/client/source/class/osparc/conversation

1 file changed

+10
-6
lines changed

services/static-webserver/client/source/class/osparc/conversation/Conversation.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@ qx.Class.define("osparc.conversation.Conversation", {
172172
if (data["conversationId"]) {
173173
this.setConversationId(data["conversationId"]);
174174
}
175-
this.reloadMessages();
176175
});
177176
this._add(addMessages);
178177
}
@@ -237,6 +236,12 @@ qx.Class.define("osparc.conversation.Conversation", {
237236
},
238237

239238
addMessage: function(message) {
239+
// ignore it if it was already there
240+
const messageIndex = this.__messages.findIndex(msg => msg["messageId"] === message["messageId"]);
241+
if (messageIndex !== -1) {
242+
return;
243+
}
244+
240245
// it's not provided by the backend
241246
message["projectId"] = this.__studyData["uuid"];
242247

@@ -247,8 +252,6 @@ qx.Class.define("osparc.conversation.Conversation", {
247252
switch (message["type"]) {
248253
case "MESSAGE":
249254
control = new osparc.conversation.MessageUI(message, this.__studyData);
250-
control.addListener("messageEdited", () => this.reloadMessages());
251-
control.addListener("messageDeleted", () => this.reloadMessages());
252255
break;
253256
case "NOTIFICATION":
254257
control = new osparc.conversation.NotificationUI(message);
@@ -263,10 +266,11 @@ qx.Class.define("osparc.conversation.Conversation", {
263266
const messageIndex = this.__messages.findIndex(msg => msg["messageId"] === messageId);
264267
if (messageIndex !== -1) {
265268
this.__messages.splice(messageIndex, 1);
266-
}
267-
this.__updateMessagesNumber();
268269

269-
console.log(this.__messagesList.getChildren());
270+
this.__updateMessagesNumber();
271+
272+
console.log(this.__messagesList.getChildren());
273+
}
270274
},
271275
}
272276
});

0 commit comments

Comments
 (0)