Skip to content

Commit be011ee

Browse files
author
Andrei Neagu
committed
refactor
1 parent b146e41 commit be011ee

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

packages/service-library/src/servicelib/fastapi/long_running_tasks/_client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def _get_url(self, path: str) -> str:
137137
return f"{url}"
138138

139139
@retry_on_http_errors
140-
async def get_task_status( # type:ignore[override]
140+
async def get_task_status(
141141
self, task_id: TaskId, *, timeout: PositiveFloat | None = None # noqa: ASYNC109
142142
) -> TaskStatus:
143143
timeout = timeout or self._client_configuration.default_timeout
@@ -156,7 +156,7 @@ async def get_task_status( # type:ignore[override]
156156
return TaskStatus.model_validate(result.json())
157157

158158
@retry_on_http_errors
159-
async def get_task_result( # type:ignore[override]
159+
async def get_task_result(
160160
self, task_id: TaskId, *, timeout: PositiveFloat | None = None # noqa: ASYNC109
161161
) -> Any | None:
162162
timeout = timeout or self._client_configuration.default_timeout
@@ -175,7 +175,7 @@ async def get_task_result( # type:ignore[override]
175175
return result.json()
176176

177177
@retry_on_http_errors
178-
async def remove_task( # type:ignore[override]
178+
async def remove_task(
179179
self, task_id: TaskId, *, timeout: PositiveFloat | None = None # noqa: ASYNC109
180180
) -> None:
181181
timeout = timeout or self._client_configuration.default_timeout

packages/service-library/tests/fastapi/long_running_tasks/test_long_running_tasks_context_manager.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
GenericClientError,
2525
TaskClientTimeoutError,
2626
TaskExceptionError,
27-
TaskNotFoundError,
2827
)
2928
from servicelib.long_running_tasks.models import (
3029
ProgressMessage,
@@ -48,9 +47,7 @@
4847
async def _assert_task_removed(
4948
base_client: HttpClient, task_id: TaskId, router_prefix: str
5049
) -> None:
51-
with pytest.raises(
52-
(GenericClientError, TaskNotFoundError), match=f"No task with {task_id} found"
53-
):
50+
with pytest.raises(GenericClientError, match=f"No task with {task_id} found"):
5451
await base_client.get_task_status(task_id)
5552

5653

0 commit comments

Comments
 (0)