Skip to content

Commit be8fac6

Browse files
author
Andrei Neagu
committed
fixed broken tests
1 parent 39a51ae commit be8fac6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ async def service_save_state(
173173
size = await sidecars_client.save_service_state(
174174
scheduler_data.endpoint, progress_callback=progress_callback
175175
)
176-
if size > 0:
176+
if size and size > 0:
177177
get_instrumentation(app).dynamic_sidecar_metrics.push_service_state_rate.labels(
178178
**get_metrics_labels(scheduler_data)
179179
).observe(get_rate(size, duration.to_float()))
@@ -480,7 +480,7 @@ async def _pull_output_ports_with_metrics() -> None:
480480
size: int = await sidecars_client.pull_service_output_ports(
481481
dynamic_sidecar_endpoint
482482
)
483-
if size > 0:
483+
if size and size > 0:
484484
get_instrumentation(
485485
app
486486
).dynamic_sidecar_metrics.output_ports_pull_rate.labels(
@@ -505,7 +505,7 @@ async def _restore_service_state_with_metrics() -> None:
505505
with track_duration() as duration:
506506
size = await sidecars_client.restore_service_state(dynamic_sidecar_endpoint)
507507

508-
if size > 0:
508+
if size and size > 0:
509509
get_instrumentation(
510510
app
511511
).dynamic_sidecar_metrics.pull_service_state_rate.labels(

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ async def retrieve_service_inputs(
464464
)
465465
duration = time.time() - started
466466

467-
if transferred_bytes > 0:
467+
if transferred_bytes and transferred_bytes > 0:
468468
get_instrumentation(
469469
self.app
470470
).dynamic_sidecar_metrics.input_ports_pull_rate.labels(

0 commit comments

Comments
 (0)