Skip to content

Commit bed5921

Browse files
authored
🐛 Bugfix: catalog was broken (#5433)
1 parent f4074a3 commit bed5921

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

services/static-webserver/client/source/class/osparc/desktop/WorkbenchView.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
350350
alignX: "center",
351351
marginLeft: 10
352352
});
353+
osparc.utils.Utils.setIdToWidget(addNewNodeBtn, "newNodeBtn");
353354
addNewNodeBtn.addListener("execute", () => {
354355
this.__workbenchUI.openServiceCatalog({
355356
x: 50,

services/static-webserver/client/source/class/osparc/info/ServiceUtils.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ qx.Class.define("osparc.info.ServiceUtils", {
6060
version.set({
6161
value: serviceVersion
6262
});
63+
osparc.utils.Utils.setIdToWidget(version, "serviceVersion");
6364
return version;
6465
},
6566

services/static-webserver/client/source/class/osparc/service/ServiceListItem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ qx.Class.define("osparc.service.ServiceListItem", {
9696
this.getChildControl("icon").setSource(this.self().SERVICE_ICON);
9797
}
9898
serviceModel.bind("name", this.getChildControl("title"), "value");
99-
serviceModel.bind("description", this.getChildControl("description-md"), "value");
99+
serviceModel.bind("description", this.getChildControl("description"), "value");
100100

101101
// ITEM
102102
this.__applyLatestVersion(serviceModel);

tests/e2e-playwright/tests/sleepers/sleepers.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def test_sleepers(
100100
),
101101
):
102102
for _ in range(1, num_sleepers):
103-
page.get_by_text("New Node").click()
103+
page.get_by_test_id("newNodeBtn").click()
104104
page.get_by_placeholder("Filter").click()
105105
page.get_by_placeholder("Filter").fill("sleeper")
106106
page.get_by_placeholder("Filter").press("Enter")
@@ -117,11 +117,7 @@ def test_sleepers(
117117
) as ctx:
118118
sleeper.click()
119119
page.keyboard.press("i")
120-
version_title_selector = page.get_by_text("VERSION")
121-
version_selector = version_title_selector.locator(
122-
"xpath=following-sibling::div"
123-
).nth(0)
124-
version_string = version_selector.text_content()
120+
version_string = page.get_by_test_id("serviceVersion").text_content()
125121
ctx.logger.info("found sleeper version: %s", version_string)
126122
assert version_string
127123
sleeper_version = parse_version(version_string)

0 commit comments

Comments
 (0)