Skip to content

Commit bf41cfb

Browse files
committed
storage_data_deleted -> storage_assets_deleted
1 parent 4fed7f3 commit bf41cfb

File tree

12 files changed

+36
-36
lines changed

12 files changed

+36
-36
lines changed

packages/postgres-database/src/simcore_postgres_database/models/projects_to_jobs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@
2929
"the parent resource name is shelves/shelf1.",
3030
),
3131
sa.Column(
32-
"storage_data_deleted",
32+
"storage_assets_deleted",
3333
sa.Boolean,
3434
nullable=False,
35-
doc="Indicates whether the job's S3 data has been actively deleted.",
35+
doc="Indicates whether the job's S3 assets have been actively deleted.",
3636
),
3737
# Composite key (project_uuid, job_parent_resource_name) uniquely identifies very row
3838
sa.UniqueConstraint(

packages/pytest-simcore/src/pytest_simcore/helpers/webserver_rpc_server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ async def mark_project_as_job(
4343
user_id: UserID,
4444
project_uuid: ProjectID,
4545
job_parent_resource_name: str,
46-
storage_data_deleted: bool,
46+
storage_assets_deleted: bool,
4747
) -> None:
4848
assert rpc_client
4949

5050
assert not job_parent_resource_name.startswith("/") # nosec
5151
assert "/" in job_parent_resource_name # nosec
5252
assert not job_parent_resource_name.endswith("/") # nosec
53-
assert isinstance(storage_data_deleted, bool)
53+
assert isinstance(storage_assets_deleted, bool)
5454

5555
assert product_name
5656
assert user_id

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/webserver/projects.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ async def mark_project_as_job(
3333
user_id: UserID,
3434
project_uuid: ProjectID,
3535
job_parent_resource_name: str,
36-
storage_data_deleted: bool,
36+
storage_assets_deleted: bool,
3737
) -> None:
3838

3939
result = await rpc_client.request(
@@ -43,7 +43,7 @@ async def mark_project_as_job(
4343
user_id=user_id,
4444
project_uuid=project_uuid,
4545
job_parent_resource_name=job_parent_resource_name,
46-
storage_data_deleted=storage_data_deleted,
46+
storage_assets_deleted=storage_assets_deleted,
4747
)
4848
assert result is None
4949

services/api-server/src/simcore_service_api_server/_service_jobs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ async def create_job(
145145
user_id=self.user_id,
146146
project_uuid=new_project.uuid,
147147
job_parent_resource_name=pre_job.runner_name,
148-
storage_data_deleted=False,
148+
storage_assets_deleted=False,
149149
)
150150

151151
assert new_project # nosec
@@ -203,5 +203,5 @@ async def delete_job_assets(
203203
user_id=self.user_id,
204204
project_uuid=job_id,
205205
job_parent_resource_name=job_parent_resource_name,
206-
storage_data_deleted=True,
206+
storage_assets_deleted=True,
207207
)

services/api-server/src/simcore_service_api_server/api/routes/studies_jobs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ async def create_study_job(
164164
user_id=user_id,
165165
project_uuid=job.id,
166166
job_parent_resource_name=job.runner_name,
167-
storage_data_deleted=False,
167+
storage_assets_deleted=False,
168168
)
169169

170170
project_inputs = await webserver_api.get_project_inputs(project_id=project.uuid)

services/api-server/src/simcore_service_api_server/services_rpc/wb_api_server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,15 +249,15 @@ async def mark_project_as_job(
249249
user_id: UserID,
250250
project_uuid: ProjectID,
251251
job_parent_resource_name: RelativeResourceName,
252-
storage_data_deleted: bool,
252+
storage_assets_deleted: bool,
253253
):
254254
await projects_rpc.mark_project_as_job(
255255
rpc_client=self._client,
256256
product_name=product_name,
257257
user_id=user_id,
258258
project_uuid=project_uuid,
259259
job_parent_resource_name=job_parent_resource_name,
260-
storage_data_deleted=storage_data_deleted,
260+
storage_assets_deleted=storage_assets_deleted,
261261
)
262262

263263
@_exception_mapper(

services/api-server/tests/unit/test_api_solver_jobs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ async def test_start_solver_job_conflict(
364364
job_parent_resource_name="studies/96642f2a-a72c-11ef-8776-02420a00087d",
365365
storage_assets_deleted=True,
366366
),
367-
id="storage_data_deleted",
367+
id="storage_assets_deleted",
368368
)
369369
],
370370
)

services/web/server/src/simcore_service_webserver/projects/_controller/projects_rpc.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ async def mark_project_as_job(
3838
user_id: UserID,
3939
project_uuid: ProjectID,
4040
job_parent_resource_name: str,
41-
storage_data_deleted: bool,
41+
storage_assets_deleted: bool,
4242
) -> None:
4343

4444
try:
@@ -49,7 +49,7 @@ async def mark_project_as_job(
4949
user_id=user_id,
5050
project_uuid=project_uuid,
5151
job_parent_resource_name=job_parent_resource_name,
52-
storage_data_deleted=storage_data_deleted,
52+
storage_assets_deleted=storage_assets_deleted,
5353
)
5454
except ProjectInvalidRightsError as err:
5555
raise ProjectForbiddenRpcError.from_domain_error(err) from err
@@ -99,7 +99,7 @@ async def list_projects_marked_as_jobs(
9999
created_at=project.creation_date,
100100
modified_at=project.last_change_date,
101101
job_parent_resource_name=project.job_parent_resource_name,
102-
storage_assets_deleted=project.storage_data_deleted,
102+
storage_assets_deleted=project.storage_assets_deleted,
103103
)
104104
for project in projects
105105
]
@@ -153,7 +153,7 @@ async def get_project_marked_as_job(
153153
created_at=project.creation_date,
154154
modified_at=project.last_change_date,
155155
job_parent_resource_name=project.job_parent_resource_name,
156-
storage_assets_deleted=project.storage_data_deleted,
156+
storage_assets_deleted=project.storage_assets_deleted,
157157
)
158158

159159

services/web/server/src/simcore_service_webserver/projects/_jobs_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ async def set_project_as_job(
3232
job_parent_resource_name: Annotated[
3333
str, AfterValidator(_validate_job_parent_resource_name)
3434
],
35-
storage_data_deleted: bool,
35+
storage_assets_deleted: bool,
3636
) -> None:
3737

3838
await check_user_project_permission(
@@ -48,7 +48,7 @@ async def set_project_as_job(
4848
await repo.set_project_as_job(
4949
project_uuid=project_uuid,
5050
job_parent_resource_name=job_parent_resource_name,
51-
storage_assets_deleted=storage_data_deleted,
51+
storage_assets_deleted=storage_assets_deleted,
5252
)
5353

5454

services/web/server/src/simcore_service_webserver/projects/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class ProjectJobDBGet(ProjectDBGet):
8181
workbench: NodesDict
8282

8383
job_parent_resource_name: str
84-
storage_data_deleted: bool
84+
storage_assets_deleted: bool
8585

8686

8787
class ProjectWithTrashExtra(ProjectDBGet):

0 commit comments

Comments
 (0)