Skip to content

Commit c001aaa

Browse files
committed
@sanderegg change names
1 parent 75551be commit c001aaa

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

services/director-v2/src/simcore_service_director_v2/api/routes/computations.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -464,9 +464,9 @@ async def get_computation(
464464
detail="The tasks referenced by the pipeline are missing",
465465
) from exc
466466
# create the complete DAG graph
467-
complete_dag = create_complete_dag_from_tasks(pipeline_info.all_tasks)
467+
complete_dag = create_complete_dag_from_tasks(pipeline_info.project_tasks)
468468
pipeline_details = await compute_pipeline_details(
469-
complete_dag, pipeline_info.pipeline_dag, pipeline_info.filtered_tasks
469+
complete_dag, pipeline_info.pipeline_dag, pipeline_info.pipeline_tasks
470470
)
471471

472472
# get run details if any
@@ -499,10 +499,10 @@ async def get_computation(
499499
iteration=last_run.iteration if last_run else None,
500500
result=None,
501501
started=compute_pipeline_started_timestamp(
502-
pipeline_info.pipeline_dag, pipeline_info.all_tasks
502+
pipeline_info.pipeline_dag, pipeline_info.project_tasks
503503
),
504504
stopped=compute_pipeline_stopped_timestamp(
505-
pipeline_info.pipeline_dag, pipeline_info.all_tasks
505+
pipeline_info.pipeline_dag, pipeline_info.project_tasks
506506
),
507507
submitted=last_run.created if last_run else None,
508508
)

services/director-v2/src/simcore_service_director_v2/api/routes/computations_tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ async def get_all_tasks_log_files(
6565
status_code=status.HTTP_409_CONFLICT,
6666
detail="The tasks referenced by the pipeline are missing",
6767
) from exc
68-
iter_task_ids = (t.node_id for t in info.filtered_tasks)
68+
iter_task_ids = (t.node_id for t in info.pipeline_tasks)
6969

7070
tasks_logs_files: list[TaskLogFileGet] = await logged_gather(
7171
*[

services/director-v2/src/simcore_service_director_v2/api/rpc/_computations_tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ async def get_computation_task_log_file_ids(
3535
except (PipelineNotFoundError, PipelineTaskMissingError) as exc:
3636
raise ComputationalTaskMissingError(project_id=project_id) from exc
3737

38-
iter_task_ids = (t.node_id for t in info.filtered_tasks)
38+
iter_task_ids = (t.node_id for t in info.pipeline_tasks)
3939

4040
return [
4141
TaskLogFileIdGet(

services/director-v2/src/simcore_service_director_v2/models/comp_tasks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ class ComputationTaskForRpcDBGet(BaseModel):
281281

282282
class PipelineInfo(BaseModel):
283283
pipeline_dag: nx.DiGraph
284-
all_tasks: list[CompTaskAtDB]
285-
filtered_tasks: list[CompTaskAtDB]
284+
project_tasks: list[CompTaskAtDB]
285+
pipeline_tasks: list[CompTaskAtDB]
286286

287287
model_config = ConfigDict(arbitrary_types_allowed=True)

services/director-v2/src/simcore_service_director_v2/utils/computations_tasks.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ async def _get_pipeline_info(
3131
]
3232

3333
return PipelineInfo(
34-
pipeline_dag=pipeline_dag, all_tasks=all_tasks, filtered_tasks=filtered_tasks
34+
pipeline_dag=pipeline_dag,
35+
project_tasks=all_tasks,
36+
pipeline_tasks=filtered_tasks,
3537
)
3638

3739

@@ -54,7 +56,7 @@ async def validate_pipeline(
5456
)
5557

5658
# check that we have the expected tasks
57-
if len(pipeline_info.filtered_tasks) != len(pipeline_info.pipeline_dag):
59+
if len(pipeline_info.pipeline_tasks) != len(pipeline_info.pipeline_dag):
5860
raise PipelineTaskMissingError(project_id=project_id)
5961

6062
return pipeline_info

0 commit comments

Comments
 (0)