@pcrespov review

sanderegg · web-flow · commit c091814249f5 · 2025-09-15T10:37:42.000+02:00
diff --git a/packages/service-library/src/servicelib/long_running_tasks/task.py b/packages/service-library/src/servicelib/long_running_tasks/task.py
@@ -335,6 +335,7 @@ async def _tasks_monitor(self) -> None:
                     result_field = ResultField(
                         str_error=dumps(TaskCancelledError(task_id=task_id))
                     )
+                    # NOTE: if the task is itself cancelled it shall re-raise: see https://superfastpython.com/asyncio-cancellederror-consumed/
                     current_task = asyncio.current_task()
                     assert current_task is not None  # nosec
                     if current_task.cancelling() > 0:

Original file line number	Diff line number	Diff line change
`@@ -335,6 +335,7 @@ async def _tasks_monitor(self) -> None:`
`335`	`335`	`result_field = ResultField(`
`336`	`336`	`str_error=dumps(TaskCancelledError(task_id=task_id))`
`337`	`337`	`)`
	`338`	`+ # NOTE: if the task is itself cancelled it shall re-raise: see https://superfastpython.com/asyncio-cancellederror-consumed/`
`338`	`339`	`current_task = asyncio.current_task()`
`339`	`340`	`assert current_task is not None # nosec`
`340`	`341`	`if current_task.cancelling() > 0:`