Skip to content

Commit c2de0e1

Browse files
GitHKAndrei Neagu
andauthored
🐛 Avoids raising exceptions when the target container of a hook is not found (#8156)
Co-authored-by: Andrei Neagu <[email protected]>
1 parent ba41af4 commit c2de0e1

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/containers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from asyncio import Lock
55
from typing import Annotated, Any, Final
66

7+
from aiodocker import DockerError
78
from common_library.json_serialization import json_loads
89
from fastapi import APIRouter, Depends, HTTPException
910
from fastapi import Path as PathParam
@@ -166,6 +167,7 @@ async def get_containers_activity(
166167
ContainerExecContainerNotFoundError,
167168
ContainerExecCommandFailedError,
168169
ContainerExecTimeoutError,
170+
DockerError,
169171
):
170172
_logger.warning(
171173
"Could not run inactivity command '%s' in container '%s'",

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks_utils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from datetime import timedelta
44
from typing import Final
55

6+
from aiodocker import DockerError
67
from models_library.callbacks_mapping import UserServiceCommand
78
from servicelib.logging_utils import log_context
89

@@ -39,6 +40,7 @@ async def run_before_shutdown_actions(
3940
ContainerExecContainerNotFoundError,
4041
ContainerExecCommandFailedError,
4142
ContainerExecTimeoutError,
43+
DockerError,
4244
):
4345
_logger.warning(
4446
"Could not run before_shutdown command %s in container %s",

0 commit comments

Comments
 (0)