errors

Author: pcrespov

services/web/server/src/simcore_service_webserver/products/_controller/rest_exceptions.py

@@ -6,12 +6,15 @@
     exception_handling_decorator,
     to_exceptions_handlers_map,
 )
-from ..errors import ProductNotFoundError
+from ..errors import MissingStripeConfigError, ProductNotFoundError
 
 _TO_HTTP_ERROR_MAP: ExceptionToHttpErrorMap = {
     ProductNotFoundError: HttpErrorInfo(
         status.HTTP_404_NOT_FOUND, "{product_name} was not found"
     ),
+    MissingStripeConfigError: HttpErrorInfo(
+        status.HTTP_503_SERVICE_UNAVAILABLE, MissingStripeConfigError.msg_template
+    ),
 }
 
 

services/web/server/src/simcore_service_webserver/products/_service.py

@@ -12,6 +12,7 @@
 from ._repository import ProductRepository
 from .errors import (
     BelowMinimumPaymentError,
+    MissingStripeConfigError,
     ProductNotFoundError,
     ProductPriceNotDefinedError,
     ProductTemplateNotFoundError,
@@ -116,8 +117,9 @@ async def get_product_stripe_info(
         or "missing!!" in product_stripe_info.stripe_price_id
         or "missing!!" in product_stripe_info.stripe_tax_rate_id
     ):
-        msg = f"Missing product stripe for product {product_name}"
-        raise ValueError(msg)
+        raise MissingStripeConfigError(
+            product_name=product_name, product_stripe_info=product_stripe_info
+        )
     return product_stripe_info
 
 

services/web/server/src/simcore_service_webserver/products/errors.py

@@ -1,8 +1,7 @@
 from ..errors import WebServerBaseError
 
 
-class ProductError(WebServerBaseError, ValueError):
-    ...
+class ProductError(WebServerBaseError, ValueError): ...
 
 
 class ProductNotFoundError(ProductError):
@@ -19,3 +18,7 @@ class BelowMinimumPaymentError(ProductError):
 
 class ProductTemplateNotFoundError(ProductError):
     msg_template = "Missing template {template_name} for product"
+
+
+class MissingStripeConfigError(ProductError):
+    msg_template = "Missing product stripe for product {product_name}"

services/web/server/tests/unit/with_dbs/04/products/test_products_service.py

@@ -10,7 +10,10 @@
 from models_library.products import ProductName
 from simcore_service_webserver.products import products_service
 from simcore_service_webserver.products._repository import ProductRepository
-from simcore_service_webserver.products.errors import ProductPriceNotDefinedError
+from simcore_service_webserver.products.errors import (
+    MissingStripeConfigError,
+    ProductPriceNotDefinedError,
+)
 
 
 @pytest.fixture
@@ -46,7 +49,7 @@ async def test_get_product_stripe_info(
     # this feature is currently setup from adminer by an operator
 
     # default is not configured
-    with pytest.raises(ValueError, match=default_product_name):
+    with pytest.raises(MissingStripeConfigError, match=default_product_name):
         await products_service.get_product_stripe_info(
             app, product_name=default_product_name
         )