@sanderegg review: PC this attribute does not exist and mypy does not like it

Author: pcrespov

services/web/server/src/simcore_service_webserver/products/_web_helpers.py

@@ -24,8 +24,7 @@ def get_product_name(request: web.Request) -> str:
     try:
         product_name: str = request[RQ_PRODUCT_KEY]
     except KeyError as exc:
-        error = UnknownProductError()
-        error.add_note("TIP: Check products middleware")
+        error = UnknownProductError(tip="Check products middleware")
         raise error from exc
     return product_name
 

services/web/server/src/simcore_service_webserver/session/plugin.py

@@ -41,4 +41,9 @@ def setup_session(app: web.Application):
         samesite=settings.SESSION_COOKIE_SAMESITE,
     )
     aiohttp_session.setup(app=app, storage=encrypted_cookie_sessions)
-    app.middlewares[-1].__middleware_name__ = f"{__name__}.session"  # type: ignore[attr-defined] # PC this attribute does not exist and mypy does not like it
+    setattr(  # noqa: B010
+        # aiohttp_session.setup has appended a middleware. We add an identifier (mostly for debugging)
+        app.middlewares[-1],
+        "__middleware_name__",
+        f"{__name__}.session",
+    )