@GitHK review: validate on server side

Author: pcrespov

services/catalog/src/simcore_service_catalog/api/rpc/_services.py

@@ -13,7 +13,7 @@
 from models_library.rpc_pagination import DEFAULT_NUMBER_OF_ITEMS_PER_PAGE, PageLimitInt
 from models_library.services_types import ServiceKey, ServiceVersion
 from models_library.users import UserID
-from pydantic import NonNegativeInt
+from pydantic import NonNegativeInt, ValidationError, validate_call
 from pyinstrument import Profiler
 from servicelib.logging_utils import log_decorator
 from servicelib.rabbitmq import RPCRouter
@@ -53,8 +53,9 @@ async def _wrapper(app: FastAPI, **kwargs):
     return _wrapper
 
 
-@router.expose(reraise_if_error_type=(CatalogForbiddenError,))
+@router.expose(reraise_if_error_type=(CatalogForbiddenError, ValidationError))
 @_profile_rpc_call
+@validate_call(config={"arbitrary_types_allowed": True})
 async def list_services_paginated(
     app: FastAPI,
     *,
@@ -88,9 +89,16 @@ async def list_services_paginated(
     )
 
 
-@router.expose(reraise_if_error_type=(CatalogItemNotFoundError, CatalogForbiddenError))
+@router.expose(
+    reraise_if_error_type=(
+        CatalogItemNotFoundError,
+        CatalogForbiddenError,
+        ValidationError,
+    )
+)
 @log_decorator(_logger, level=logging.DEBUG)
 @_profile_rpc_call
+@validate_call(config={"arbitrary_types_allowed": True})
 async def get_service(
     app: FastAPI,
     *,
@@ -116,8 +124,15 @@ async def get_service(
     return service
 
 
-@router.expose(reraise_if_error_type=(CatalogItemNotFoundError, CatalogForbiddenError))
+@router.expose(
+    reraise_if_error_type=(
+        CatalogItemNotFoundError,
+        CatalogForbiddenError,
+        ValidationError,
+    )
+)
 @log_decorator(_logger, level=logging.DEBUG)
+@validate_call(config={"arbitrary_types_allowed": True})
 async def update_service(
     app: FastAPI,
     *,
@@ -147,8 +162,15 @@ async def update_service(
     return service
 
 
-@router.expose(reraise_if_error_type=(CatalogItemNotFoundError, CatalogForbiddenError))
+@router.expose(
+    reraise_if_error_type=(
+        CatalogItemNotFoundError,
+        CatalogForbiddenError,
+        ValidationError,
+    )
+)
 @log_decorator(_logger, level=logging.DEBUG)
+@validate_call(config={"arbitrary_types_allowed": True})
 async def check_for_service(
     app: FastAPI,
     *,
@@ -169,8 +191,9 @@ async def check_for_service(
     )
 
 
-@router.expose(reraise_if_error_type=(CatalogForbiddenError,))
+@router.expose(reraise_if_error_type=(CatalogForbiddenError, ValidationError))
 @log_decorator(_logger, level=logging.DEBUG)
+@validate_call(config={"arbitrary_types_allowed": True})
 async def batch_get_my_services(
     app: FastAPI,
     *,