Skip to content

Commit c5dbc5c

Browse files
author
Andrei Neagu
committed
fixed tests
1 parent aaa6aa4 commit c5dbc5c

File tree

3 files changed

+29
-15
lines changed

3 files changed

+29
-15
lines changed

services/web/server/tests/unit/with_dbs/02/test_projects_nodes_handler.py

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ def inc_running_services(self, *args, **kwargs): # noqa: ARG002
414414
running_services = _RunningServices()
415415
assert running_services.running_services_uuids == []
416416
mocked_director_v2_api[
417-
"director_v2.api.list_dynamic_services"
417+
"dynamic_scheduler.api.list_dynamic_services"
418418
].side_effect = running_services.num_services
419419
mocked_director_v2_api[
420420
"dynamic_scheduler.api.run_dynamic_service"
@@ -481,7 +481,9 @@ async def test_create_node_does_not_start_dynamic_node_if_there_are_already_too_
481481
max_amount_of_auto_started_dyn_services
482482
)
483483
all_service_uuids = list(project["workbench"])
484-
mocked_director_v2_api["director_v2.api.list_dynamic_services"].return_value = [
484+
mocked_director_v2_api[
485+
"dynamic_scheduler.api.list_dynamic_services"
486+
].return_value = [
485487
{"service_uuid": service_uuid} for service_uuid in all_service_uuids
486488
]
487489
url = client.app.router["create_node"].url_for(project_id=project["uuid"])
@@ -539,7 +541,7 @@ async def inc_running_services(self, *args, **kwargs): # noqa: ARG002
539541
running_services = _RunninServices()
540542
assert running_services.running_services_uuids == []
541543
mocked_director_v2_api[
542-
"director_v2.api.list_dynamic_services"
544+
"dynamic_scheduler.api.list_dynamic_services"
543545
].side_effect = running_services.num_services
544546
mocked_director_v2_api[
545547
"dynamic_scheduler.api.run_dynamic_service"
@@ -593,7 +595,9 @@ async def test_create_node_does_start_dynamic_node_if_max_num_set_to_0(
593595
assert client.app
594596
project = await user_project_with_num_dynamic_services(faker.pyint(min_value=3))
595597
all_service_uuids = list(project["workbench"])
596-
mocked_director_v2_api["director_v2.api.list_dynamic_services"].return_value = [
598+
mocked_director_v2_api[
599+
"dynamic_scheduler.api.list_dynamic_services"
600+
].return_value = [
597601
{"service_uuid": service_uuid} for service_uuid in all_service_uuids
598602
]
599603
url = client.app.router["create_node"].url_for(project_id=project["uuid"])
@@ -682,7 +686,7 @@ async def test_delete_node(
682686
)
683687
for service_uuid in running_dy_services
684688
]
685-
# mocked_director_v2_api["director_v2.api.list_dynamic_services"].return_value = [
689+
# mocked_director_v2_api["dynamic_scheduler.api.list_dynamic_services"].return_value = [
686690
# {"service_uuid": service_uuid} for service_uuid in running_dy_services
687691
# ]
688692
for node_id in user_project["workbench"]:
@@ -696,9 +700,11 @@ async def test_delete_node(
696700
continue
697701

698702
mocked_director_v2_api[
699-
"director_v2.api.list_dynamic_services"
703+
"dynamic_scheduler.api.list_dynamic_services"
700704
].assert_called_once()
701-
mocked_director_v2_api["director_v2.api.list_dynamic_services"].reset_mock()
705+
mocked_director_v2_api[
706+
"dynamic_scheduler.api.list_dynamic_services"
707+
].reset_mock()
702708

703709
if node_id in running_dy_services:
704710
mocked_director_v2_api[
@@ -788,7 +794,9 @@ async def test_start_node_raises_if_dynamic_services_limit_attained(
788794
max_amount_of_auto_started_dyn_services
789795
)
790796
all_service_uuids = list(project["workbench"])
791-
mocked_director_v2_api["director_v2.api.list_dynamic_services"].return_value = [
797+
mocked_director_v2_api[
798+
"dynamic_scheduler.api.list_dynamic_services"
799+
].return_value = [
792800
{"service_uuid": service_uuid} for service_uuid in all_service_uuids
793801
]
794802
# start the node, shall work as expected
@@ -821,7 +829,9 @@ async def test_start_node_starts_dynamic_service_if_max_number_of_services_set_t
821829
assert client.app
822830
project = await user_project_with_num_dynamic_services(faker.pyint(min_value=3))
823831
all_service_uuids = list(project["workbench"])
824-
mocked_director_v2_api["director_v2.api.list_dynamic_services"].return_value = [
832+
mocked_director_v2_api[
833+
"dynamic_scheduler.api.list_dynamic_services"
834+
].return_value = [
825835
{"service_uuid": service_uuid} for service_uuid in all_service_uuids
826836
]
827837
# start the node, shall work as expected

services/web/server/tests/unit/with_dbs/02/test_projects_states_handlers.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,9 @@ async def test_open_project_with_disable_service_auto_start_set_overrides_behavi
587587
project = await user_project_with_num_dynamic_services(num_of_dyn_services)
588588
all_service_uuids = list(project["workbench"])
589589
for num_service_already_running in range(num_of_dyn_services):
590-
mocked_director_v2_api["director_v2.api.list_dynamic_services"].return_value = [
590+
mocked_director_v2_api[
591+
"dynamic_scheduler.api.list_dynamic_services"
592+
].return_value = [
591593
{"service_uuid": all_service_uuids[service_id]}
592594
for service_id in range(num_service_already_running)
593595
]
@@ -817,10 +819,12 @@ async def test_close_project(
817819
mocked_notifications_plugin["subscribe"].assert_called_once_with(
818820
client.app, ProjectID(user_project["uuid"])
819821
)
820-
mocked_director_v2_api["director_v2.api.list_dynamic_services"].assert_any_call(
821-
client.app, user_id, user_project["uuid"]
822-
)
823-
mocked_director_v2_api["director_v2.api.list_dynamic_services"].reset_mock()
822+
mocked_director_v2_api[
823+
"dynamic_scheduler.api.list_dynamic_services"
824+
].assert_any_call(client.app, user_id, user_project["uuid"])
825+
mocked_director_v2_api[
826+
"dynamic_scheduler.api.list_dynamic_services"
827+
].reset_mock()
824828
else:
825829
mocked_notifications_plugin["subscribe"].assert_not_called()
826830

services/web/server/tests/unit/with_dbs/03/version_control/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def request_update_project(
186186
return_value=ServiceResourcesDict(),
187187
)
188188
mocker.patch(
189-
"simcore_service_webserver.director_v2.api.list_dynamic_services",
189+
"simcore_service_webserver.dynamic_scheduler.api.list_dynamic_services",
190190
return_value=[],
191191
)
192192

0 commit comments

Comments
 (0)