draft implemeting service layer

Author: pcrespov

services/web/server/src/simcore_service_webserver/projects/_controller/groups_rest.py

@@ -62,20 +62,28 @@ async def share_project(request: web.Request):
         body_params.sharee_email,
     ):
 
-        code: IDStr = await _groups_service.create_confirmation_action_to_share_project(
-            app=request.app,
-            user_id=req_ctx.user_id,
-            project_id=path_params.project_id,
-            sharee_email=body_params.sharee_email,
-            read=body_params.read,
-            write=body_params.write,
-            delete=body_params.delete,
-            product_name=req_ctx.product_name,
+        confirmation_code: IDStr = (
+            await _groups_service.create_confirmation_action_to_share_project(
+                app=request.app,
+                user_id=req_ctx.user_id,
+                project_id=path_params.project_id,
+                sharee_email=body_params.sharee_email,
+                read=body_params.read,
+                write=body_params.write,
+                delete=body_params.delete,
+                product_name=req_ctx.product_name,
+            )
         )
 
-        confirmation_link: str = login_web.make_confirmation_link(request, code=code)
+        confirmation_link: str = login_web.make_confirmation_link(
+            request, code=confirmation_code
+        )
 
-        _logger.debug("Send email with confirmation link: %s", confirmation_link)
+        _logger.debug(
+            "Send email with confirmation link %s to %s ",
+            confirmation_link,
+            body_params.sharee_email,
+        )
 
         return web.json_response(status=status.HTTP_204_NO_CONTENT)
 
@@ -108,7 +116,7 @@ async def create_project_group(request: web.Request):
         request.app,
         user_id=req_ctx.user_id,
         project_id=path_params.project_id,
-        group_id=path_params.group_id,
+        sharee_group_id=path_params.group_id,
         read=body_params.read,
         write=body_params.write,
         delete=body_params.delete,

services/web/server/src/simcore_service_webserver/projects/_groups_service.py

@@ -36,7 +36,7 @@ async def create_project_group(
     *,
     user_id: UserID,
     project_id: ProjectID,
-    group_id: GroupID,
+    sharee_group_id: GroupID,
     read: bool,
     write: bool,
     delete: bool,
@@ -53,7 +53,7 @@ async def create_project_group(
     project_group_db: ProjectGroupGetDB = await _groups_repository.create_project_group(
         app=app,
         project_id=project_id,
-        group_id=group_id,
+        group_id=sharee_group_id,
         read=read,
         write=write,
         delete=delete,
@@ -189,7 +189,7 @@ async def create_confirmation_action_to_share_project(
     assert app  # nosec
 
     _logger.debug(
-        "Checking that %s in %s has enough access rights (ownership) to %s for sharing",
+        "Checking that %s in %s has enough access rights (i.e. ownership) to %s for sharing",
         f"{user_id=}",
         f"{product_name=}",
         f"{project_id=}",
@@ -201,6 +201,9 @@ async def create_confirmation_action_to_share_project(
     shared_resource_access_rights = AccessRights(read=read, write=write, delete=delete)
     shared_at = arrow.utcnow().datetime
 
+    # action will be a wrapper around create_project_group that gets primary_gid from the email
+    # action needs to be statically registered
+
     _logger.debug(
         "Creating confirmation token for action=SHARE with and producing a code:"
         "\n %s," * 6,