Skip to content

Commit c75ccae

Browse files
fix done property
1 parent 95898e6 commit c75ccae

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

services/storage/src/simcore_service_storage/api/rpc/_async_jobs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ async def get_status(
4444
return AsyncJobStatus(
4545
job_id=job_id,
4646
progress=task_status.progress_report,
47-
done=False,
47+
done=task_status.is_done,
4848
)
4949

5050

services/storage/src/simcore_service_storage/modules/celery/models.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,18 @@ class TaskState(StrEnum):
2121
ABORTED = auto()
2222

2323

24+
_TASK_DONE = {TaskState.SUCCESS, TaskState.FAILURE, TaskState.ABORTED}
25+
26+
2427
class TaskStatus(BaseModel):
2528
task_uuid: TaskUUID
2629
task_state: TaskState
2730
progress_report: ProgressReport
2831

32+
@property
33+
def is_done(self) -> bool:
34+
return self.task_state in _TASK_DONE
35+
2936
@model_validator(mode="after")
3037
def _check_consistency(self) -> Self:
3138
value = self.progress_report.actual_value

0 commit comments

Comments
 (0)