fixes sonarcloud

Author: pcrespov

services/api-server/src/simcore_service_api_server/core/application.py

@@ -16,7 +16,7 @@
 from ..services_http import catalog, director_v2, storage, webserver
 from ..services_http.rabbitmq import setup_rabbitmq
 from ._prometheus_instrumentation import setup_prometheus_instrumentation
-from .events import create_start_app_handler, create_stop_app_handler
+from .events import on_shutdown, on_startup
 from .openapi import override_openapi_method, use_route_names_as_operation_ids
 from .settings import ApplicationSettings
 
@@ -119,8 +119,8 @@ def init_app(settings: ApplicationSettings | None = None) -> FastAPI:
         )
 
     # setup app
-    app.add_event_handler("startup", create_start_app_handler(app))
-    app.add_event_handler("shutdown", create_stop_app_handler(app))
+    app.add_event_handler("startup", on_startup)
+    app.add_event_handler("shutdown", on_shutdown)
 
     exceptions.setup_exception_handlers(
         app, is_debug=settings.SC_BOOT_MODE == BootModeEnum.DEBUG

services/api-server/src/simcore_service_api_server/core/events.py

@@ -1,24 +1,15 @@
 import logging
-from collections.abc import Callable
-
-from fastapi import FastAPI
 
 from .._meta import APP_FINISHED_BANNER_MSG, APP_STARTED_BANNER_MSG
 
 _logger = logging.getLogger(__name__)
 
 
-def create_start_app_handler(app: FastAPI) -> Callable:
-    async def _on_startup() -> None:
-        _logger.info("Application starting ...")
-        print(APP_STARTED_BANNER_MSG, flush=True)  # noqa: T201
-
-    return _on_startup
-
+async def on_startup() -> None:
+    _logger.info("Application starting ...")
+    print(APP_STARTED_BANNER_MSG, flush=True)  # noqa: T201
 
-def create_stop_app_handler(app: FastAPI) -> Callable:
-    async def _on_shutdown() -> None:
-        _logger.info("Application stopping, ...")
-        print(APP_FINISHED_BANNER_MSG, flush=True)  # noqa: T201
 
-    return _on_shutdown
+async def on_shutdown() -> None:
+    _logger.info("Application stopping, ...")
+    print(APP_FINISHED_BANNER_MSG, flush=True)  # noqa: T201