Skip to content

Commit c7a0af8

Browse files
author
Andrei Neagu
committed
moved container_utils
1 parent 64d6099 commit c7a0af8

File tree

6 files changed

+13
-169
lines changed

6 files changed

+13
-169
lines changed

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/containers.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@
1414
ActivityInfoOrNone,
1515
)
1616
from pydantic import TypeAdapter, ValidationError
17-
from servicelib.fastapi.requests_decorators import cancel_on_disconnect
18-
19-
from ...core.docker_utils import docker_client
20-
from ...core.errors import (
17+
from servicelib.container_utils import (
2118
ContainerExecCommandFailedError,
2219
ContainerExecContainerNotFoundError,
2320
ContainerExecTimeoutError,
21+
run_command_in_container,
2422
)
23+
from servicelib.fastapi.requests_decorators import cancel_on_disconnect
24+
25+
from ...core.docker_utils import docker_client
2526
from ...core.settings import ApplicationSettings
2627
from ...core.validation import (
2728
ComposeSpecValidation,
@@ -30,7 +31,6 @@
3031
)
3132
from ...models.schemas.containers import ContainersComposeSpec
3233
from ...models.shared_store import SharedStore
33-
from ...modules.container_utils import run_command_in_container
3434
from ...modules.mounted_fs import MountedVolumes
3535
from ._dependencies import (
3636
get_container_restart_lock,

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/errors.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,3 @@ class VolumeNotFoundError(BaseDynamicSidecarError):
1414

1515
class UnexpectedDockerError(BaseDynamicSidecarError):
1616
msg_template = "An unexpected Docker error occurred status_code={status_code}, message={message}"
17-
18-
19-
class ContainerExecContainerNotFoundError(BaseDynamicSidecarError):
20-
msg_template = "Container '{container_name}' was not found"
21-
22-
23-
class ContainerExecTimeoutError(BaseDynamicSidecarError):
24-
msg_template = "Timed out after {timeout} while executing: '{command}'"
25-
26-
27-
class ContainerExecCommandFailedError(BaseDynamicSidecarError):
28-
msg_template = (
29-
"Command '{command}' exited with code '{exit_code}'"
30-
"and output: '{command_result}'"
31-
)

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/container_utils.py

Lines changed: 0 additions & 86 deletions
This file was deleted.

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55

66
from aiodocker import DockerError
77
from models_library.callbacks_mapping import UserServiceCommand
8-
from servicelib.logging_utils import log_context
9-
10-
from ..core.errors import (
8+
from servicelib.container_utils import (
119
ContainerExecCommandFailedError,
1210
ContainerExecContainerNotFoundError,
1311
ContainerExecTimeoutError,
12+
run_command_in_container,
1413
)
14+
from servicelib.logging_utils import log_context
15+
1516
from ..models.shared_store import SharedStore
1617
from ..modules.mounted_fs import MountedVolumes
17-
from .container_utils import run_command_in_container
1818

1919
_logger = logging.getLogger(__name__)
2020

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/prometheus_metrics.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@
1010
from fastapi import FastAPI, status
1111
from models_library.callbacks_mapping import CallbacksMapping, UserServiceCommand
1212
from pydantic import BaseModel, NonNegativeFloat, NonNegativeInt
13-
from servicelib.logging_utils import log_context
14-
from servicelib.sequences_utils import pairwise
15-
from simcore_service_dynamic_sidecar.core.errors import (
13+
from servicelib.container_utils import (
1614
ContainerExecContainerNotFoundError,
15+
run_command_in_container,
1716
)
17+
from servicelib.logging_utils import log_context
18+
from servicelib.sequences_utils import pairwise
1819

1920
from ..models.shared_store import SharedStore
20-
from .container_utils import run_command_in_container
2121

2222
_logger = logging.getLogger(__name__)
2323

services/dynamic-sidecar/tests/unit/test_modules_container_utils.py

Lines changed: 0 additions & 55 deletions
This file was deleted.

0 commit comments

Comments
 (0)