add result endpoint

Author: bisgaard-itis

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/storage/zipping.py

@@ -1,7 +1,11 @@
 from typing import Final
 
 from models_library.api_schemas_long_running_tasks.base import TaskId
-from models_library.api_schemas_long_running_tasks.tasks import TaskGet, TaskStatus
+from models_library.api_schemas_long_running_tasks.tasks import (
+    TaskGet,
+    TaskResult,
+    TaskStatus,
+)
 from models_library.api_schemas_storage import STORAGE_RPC_NAMESPACE
 from models_library.api_schemas_storage.zipping_tasks import (
     ZipTaskAbortOutput,
@@ -54,3 +58,16 @@ async def get_zipping_status(
     )
     assert isinstance(result, TaskStatus)
     return result
+
+
+async def get_zipping_result(
+    rabbitmq_rpc_client: RabbitMQRPCClient, *, task_id: TaskId
+) -> TaskResult:
+    result = await rabbitmq_rpc_client.request(
+        STORAGE_RPC_NAMESPACE,
+        _RPC_METHOD_NAME_ADAPTER.validate_python("get_zipping_result"),
+        task_id=task_id,
+        timeout_s=_DEFAULT_TIMEOUT_S,
+    )
+    assert isinstance(result, TaskResult)
+    return result

services/storage/src/simcore_service_storage/api/rabbitmq_rpc/_zipping.py

@@ -6,6 +6,7 @@
 from models_library.api_schemas_long_running_tasks.tasks import (
     TaskGet,
     TaskId,
+    TaskResult,
     TaskStatus,
 )
 from models_library.api_schemas_storage.zipping_tasks import (
@@ -43,3 +44,8 @@ async def get_zipping_status(app: FastAPI, task_id: TaskId) -> TaskStatus:
         percent=ProgressPercent(0.5),
     )
     return TaskStatus(task_progress=progress, done=False, started=datetime.now())
+
+
+@router.expose()
+async def get_zipping_result(app: FastAPI, task_id: TaskId) -> TaskResult:
+    return TaskResult(result="Here's your result.", error=None)

services/storage/tests/unit/test_zipping.py

@@ -14,7 +14,7 @@
 from servicelib.rabbitmq import RabbitMQRPCClient
 from servicelib.rabbitmq.rpc_interfaces.storage import zipping
 from settings_library.rabbit import RabbitSettings
-from simcore_service_storage.api.rabbitmq_rpc._zipping import TaskId
+from simcore_service_storage.api.rabbitmq_rpc._zipping import TaskId, TaskResult
 from simcore_service_storage.core.settings import ApplicationSettings
 
 pytest_plugins = [
@@ -79,3 +79,9 @@ async def test_get_zipping_status(rpc_client: RabbitMQRPCClient, faker: Faker):
     result = await zipping.get_zipping_status(rpc_client, task_id=_task_id)
     assert isinstance(result, TaskStatus)
     assert result.task_progress.task_id == _task_id
+
+
+async def test_get_zipping_result(rpc_client: RabbitMQRPCClient, faker: Faker):
+    _task_id = TaskId(f"{faker.uuid4()}")
+    result = await zipping.get_zipping_result(rpc_client, task_id=_task_id)
+    assert isinstance(result, TaskResult)