changed permissions

Author: sanderegg

services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rpc.py

@@ -22,6 +22,7 @@
     FunctionJobCollectionReadAccessDeniedError,
     FunctionJobCollectionsReadApiAccessDeniedError,
     FunctionJobCollectionsWriteApiAccessDeniedError,
+    FunctionJobCollectionWriteAccessDeniedError,
     FunctionJobIDNotFoundError,
     FunctionJobReadAccessDeniedError,
     FunctionJobsReadApiAccessDeniedError,
@@ -283,6 +284,7 @@ async def delete_function_job(
     reraise_if_error_type=(
         FunctionJobCollectionIDNotFoundError,
         FunctionJobCollectionReadAccessDeniedError,
+        FunctionJobCollectionWriteAccessDeniedError,
         FunctionJobCollectionsWriteApiAccessDeniedError,
     )
 )
@@ -305,6 +307,7 @@ async def delete_function_job_collection(
     reraise_if_error_type=(
         FunctionIDNotFoundError,
         FunctionReadAccessDeniedError,
+        FunctionWriteAccessDeniedError,
     )
 )
 async def update_function_title(
@@ -325,7 +328,11 @@ async def update_function_title(
 
 
 @router.expose(
-    reraise_if_error_type=(FunctionIDNotFoundError, FunctionReadAccessDeniedError)
+    reraise_if_error_type=(
+        FunctionIDNotFoundError,
+        FunctionReadAccessDeniedError,
+        FunctionWriteAccessDeniedError,
+    )
 )
 async def update_function_description(
     app: web.Application,

services/web/server/tests/unit/with_dbs/04/functions_rpc/test_function_job_collections_controller_rpc.py

@@ -17,6 +17,7 @@
 from models_library.functions_errors import (
     FunctionJobCollectionReadAccessDeniedError,
     FunctionJobCollectionsReadApiAccessDeniedError,
+    FunctionJobCollectionWriteAccessDeniedError,
     FunctionJobIDNotFoundError,
 )
 from models_library.products import ProductName
@@ -137,7 +138,7 @@ async def test_function_job_collection(
         )
 
     # Attempt to delete the function job collection by another user
-    with pytest.raises(FunctionJobCollectionReadAccessDeniedError):
+    with pytest.raises(FunctionJobCollectionWriteAccessDeniedError):
         await functions_rpc.delete_function_job_collection(
             rabbitmq_rpc_client=rpc_client,
             function_job_collection_id=registered_collection.uid,

services/web/server/tests/unit/with_dbs/04/functions_rpc/test_function_jobs_controller_rpc.py

@@ -15,6 +15,7 @@
     FunctionJobIDNotFoundError,
     FunctionJobReadAccessDeniedError,
     FunctionJobsReadApiAccessDeniedError,
+    FunctionJobWriteAccessDeniedError,
 )
 from models_library.products import ProductName
 from pytest_simcore.helpers.webserver_login import UserInfoDict
@@ -104,7 +105,7 @@ async def test_register_get_delete_function_job(
             product_name="this_is_not_osparc",
         )
 
-    with pytest.raises(FunctionJobReadAccessDeniedError):
+    with pytest.raises(FunctionJobWriteAccessDeniedError):
         # Attempt to delete the function job by another user
         await functions_rpc.delete_function_job(
             rabbitmq_rpc_client=rpc_client,
@@ -301,7 +302,6 @@ async def test_find_cached_function_jobs(
     mock_function: ProjectFunction,
     clean_functions: None,
 ):
-
     # Register the function first
     registered_function = await functions_rpc.register_function(
         rabbitmq_rpc_client=rpc_client,

services/web/server/tests/unit/with_dbs/04/functions_rpc/test_functions_controller_rpc.py

@@ -19,6 +19,7 @@
     FunctionIDNotFoundError,
     FunctionReadAccessDeniedError,
     FunctionsReadApiAccessDeniedError,
+    FunctionWriteAccessDeniedError,
 )
 from models_library.products import ProductName
 from pytest_simcore.helpers.webserver_login import UserInfoDict
@@ -88,7 +89,7 @@ async def test_register_get_delete_function(
             product_name=osparc_product_name,
         )
 
-    with pytest.raises(FunctionReadAccessDeniedError):
+    with pytest.raises(FunctionWriteAccessDeniedError):
         # Attempt to delete the function by another user
         await functions_rpc.delete_function(
             rabbitmq_rpc_client=rpc_client,
@@ -374,7 +375,7 @@ async def test_update_function_title(
     # Update the function's title by other user
     updated_title = "Updated Function Title by Other User"
     registered_function.title = updated_title
-    with pytest.raises(FunctionReadAccessDeniedError):
+    with pytest.raises(FunctionWriteAccessDeniedError):
         updated_function = await functions_rpc.update_function_title(
             rabbitmq_rpc_client=rpc_client,
             function_id=registered_function.uid,