refactor: update batch_ids_validator to use tuple type directly and improve test assertions

Author: pcrespov

packages/models-library/src/models_library/batch_operations.py

@@ -28,7 +28,7 @@ def create_batch_ids_validator(identifier_type: type[IdentifierT]) -> TypeAdapte
     """
     return TypeAdapter(
         Annotated[
-            list[identifier_type],
+            list[identifier_type],  # type: ignore[valid-type]
             BeforeValidator(_deduplicate_preserving_order),
             Field(
                 min_length=1,

services/catalog/src/simcore_service_catalog/service/catalog_services.py

@@ -586,10 +586,7 @@ async def check_catalog_service_permissions(
     return access_rights
 
 
-ServiceKeyVersionTuple = tuple[ServiceKey, ServiceVersion]
-
-
-_BatchIdsValidator = create_batch_ids_validator(ServiceKeyVersionTuple)
+_BatchIdsValidator = create_batch_ids_validator(tuple[ServiceKey, ServiceVersion])
 
 
 async def batch_get_user_services(
@@ -598,7 +595,7 @@ async def batch_get_user_services(
     *,
     product_name: ProductName,
     user_id: UserID,
-    ids: list[ServiceKeyVersionTuple],
+    ids: list[tuple[ServiceKey, ServiceVersion]],
 ) -> BatchGetUserServicesResult:
     """Batch get user services.
 

services/catalog/tests/unit/with_dbs/test_service_catalog_services.py

@@ -537,7 +537,7 @@ async def test_list_all_vs_latest_services(
         key_to_all_versions[item.key].append(item)
 
     # For each service key, verify we have the expected number of versions
-    for key, versions in key_to_all_versions.found_items():
+    for key, versions in key_to_all_versions.items():
         assert len(versions) == num_versions_per_service
 
         # Find this service in latest_found_items