@pcrespov use dict instead of del

bisgaard-itis · bisgaard-itis · commit cbd02a02cd0f · 2025-05-05T10:02:47.000+02:00
diff --git a/services/api-server/src/simcore_service_api_server/services_http/log_streaming.py b/services/api-server/src/simcore_service_api_server/services_http/log_streaming.py
@@ -85,7 +85,7 @@ async def deregister(self, job_id: JobID):
         await self._rabbit_client.remove_topics(
             LoggerRabbitMessage.get_channel_name(), topics=[f"{job_id}.*"]
         )
-        del self._log_streamers[job_id]
+        self._log_streamers.pop(job_id)
 
     @property
     def iter_log_queue_sizes(self) -> Iterator[tuple[JobID, int]]:

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ async def deregister(self, job_id: JobID):`
`85`	`85`	`await self._rabbit_client.remove_topics(`
`86`	`86`	`LoggerRabbitMessage.get_channel_name(), topics=[f"{job_id}.*"]`
`87`	`87`	`)`
`88`		`- del self._log_streamers[job_id]`
	`88`	`+ self._log_streamers.pop(job_id)`
`89`	`89`
`90`	`90`	`@property`
`91`	`91`	`def iter_log_queue_sizes(self) -> Iterator[tuple[JobID, int]]:`