Skip to content

Commit ccee1d5

Browse files
continue upgrading
1 parent 8e756b7 commit ccee1d5

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

services/invitations/src/simcore_service_invitations/services/invitations.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ class _ContentWithShortNames(InvitationContent):
2626
@classmethod
2727
def serialize(cls, model_obj: InvitationContent) -> str:
2828
"""Exports to json using *short* aliases and values in order to produce shorter codes"""
29-
model_w_short_aliases_json: str = cls.construct(
30-
**model_obj.dict(exclude_unset=True)
29+
model_w_short_aliases_json: str = cls.model_construct(
30+
**model_obj.model_dump(exclude_unset=True)
3131
).model_dump_json(exclude_unset=True, by_alias=True)
3232
# NOTE: json arguments try to minimize the amount of data
3333
# serialized. The CONS is that it relies on models in the code
@@ -38,9 +38,9 @@ def serialize(cls, model_obj: InvitationContent) -> str:
3838
@classmethod
3939
def deserialize(cls, raw_json: str) -> InvitationContent:
4040
"""Parses a json string and returns InvitationContent model"""
41-
model_w_short_aliases = cls.parse_raw(raw_json)
42-
return InvitationContent.construct(
43-
**model_w_short_aliases.dict(exclude_unset=True)
41+
model_w_short_aliases = cls.model_validate_json(raw_json)
42+
return InvitationContent.model_construct(
43+
**model_w_short_aliases.model_dump(exclude_unset=True)
4444
)
4545

4646
model_config = ConfigDict(

services/invitations/tests/unit/test_cli.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import pytest
99
from faker import Faker
1010
from models_library.products import ProductName
11+
from pydantic import TypeAdapter
1112
from pytest_simcore.helpers.monkeypatch_envs import load_dotenv, setenvs_from_dict
1213
from pytest_simcore.helpers.typing_env import EnvVarsDict
1314
from simcore_service_invitations._meta import API_VERSION
@@ -71,7 +72,10 @@ def test_invite_user_and_check_invitation(
7172
env=environs,
7273
)
7374
assert result.exit_code == os.EX_OK, result.output
74-
assert expected == InvitationInputs.parse_raw(result.stdout).dict()
75+
assert (
76+
expected
77+
== TypeAdapter(InvitationInputs).validate_json(result.stdout).model_dump()
78+
)
7579

7680

7781
def test_echo_dotenv(cli_runner: CliRunner, monkeypatch: pytest.MonkeyPatch):
@@ -93,5 +97,5 @@ def test_list_settings(cli_runner: CliRunner, app_environment: EnvVarsDict):
9397
assert result.exit_code == os.EX_OK, result.output
9498

9599
print(result.output)
96-
settings = ApplicationSettings.parse_raw(result.output)
100+
settings = TypeAdapter(ApplicationSettings).validate_json(result.output)
97101
assert settings == ApplicationSettings.create_from_envs()

0 commit comments

Comments
 (0)