Skip to content

Commit ccf7aa1

Browse files
solve merge conflicts
1 parent a6818b5 commit ccf7aa1

File tree

6 files changed

+18
-24
lines changed

6 files changed

+18
-24
lines changed

packages/models-library/src/models_library/licensed_items.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -63,20 +63,10 @@ class LicensedItemDB(BaseModel):
6363
modified: datetime
6464
trashed: datetime | None
6565

66-
licensed_resource_data: dict[str, Any] | None
67-
68-
pricing_plan_id: PricingPlanId | None
69-
product_name: ProductName | None
70-
71-
# states
72-
created: datetime
73-
modified: datetime
74-
trashed: datetime | None
75-
7666
model_config = ConfigDict(from_attributes=True)
7767

7868

7969
class LicensedItemUpdateDB(BaseModel):
80-
display_name: str | None = None
70+
licensed_resource_name: str | None = None
8171
pricing_plan_id: PricingPlanId | None = None
8272
trash: bool | None = None

packages/postgres-database/src/simcore_postgres_database/models/licensed_items.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@
66
import sqlalchemy as sa
77
from sqlalchemy.dialects import postgresql
88

9-
from ._common import RefActions, column_modified_datetime, column_trashed_datetime
9+
from ._common import (
10+
RefActions,
11+
column_created_datetime,
12+
column_modified_datetime,
13+
column_trashed_datetime,
14+
)
1015
from .base import metadata
1116

1217

@@ -42,12 +47,6 @@ class LicensedResourceType(str, enum.Enum):
4247
nullable=True,
4348
doc="Resource metadata. Used for read-only purposes",
4449
),
45-
sa.Column(
46-
"licensed_resource_data",
47-
postgresql.JSONB,
48-
nullable=True,
49-
doc="Resource metadata. Used for read-only purposes",
50-
),
5150
sa.Column(
5251
"pricing_plan_id",
5352
sa.BigInteger,
@@ -71,6 +70,7 @@ class LicensedResourceType(str, enum.Enum):
7170
nullable=True,
7271
doc="Product name identifier. If None, then the item is not exposed",
7372
),
73+
column_created_datetime(timezone=True),
7474
column_modified_datetime(timezone=True),
7575
column_trashed_datetime("licensed_item"),
7676
)

services/web/server/src/simcore_service_webserver/licenses/_licensed_items_repository.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
_logger = logging.getLogger(__name__)
3535

3636

37-
_SELECTION_ARGS = get_columns_from_db_model(licensed_items, LicensedItemDB)
3837
_SELECTION_ARGS = get_columns_from_db_model(licensed_items, LicensedItemDB)
3938

4039

@@ -63,7 +62,6 @@ async def create(
6362
.returning(*_SELECTION_ARGS)
6463
)
6564
row = result.one()
66-
row = result.one()
6765
return LicensedItemDB.model_validate(row)
6866

6967

services/web/server/src/simcore_service_webserver/licenses/_licensed_items_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ async def list_licensed_items(
5656
offset: NonNegativeInt,
5757
limit: int,
5858
order_by: OrderBy,
59-
) -> LicensedItemGetPage:
59+
) -> LicensedItemPage:
6060
total_count, items = await _licensed_items_repository.list_(
6161
app,
6262
product_name=product_name,
@@ -77,7 +77,7 @@ async def list_licensed_items(
7777
created_at=licensed_item_db.created,
7878
modified_at=licensed_item_db.modified,
7979
)
80-
for licensed_item_db in licensed_item_db_list
80+
for licensed_item_db in items
8181
],
8282
total=total_count,
8383
)

services/web/server/tests/unit/with_dbs/04/licenses/test_licensed_items_repository.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,9 @@ async def test_licensed_items_db_crud(
5252
client.app,
5353
product_name=osparc_product_name,
5454
licensed_resource_name="Model A",
55-
licensed_resource_name="Model A",
5655
licensed_resource_type=LicensedResourceType.VIP_MODEL,
57-
pricing_plan_id=pricing_plan_id,
5856
licensed_resource_data=VIP_DETAILS_EXAMPLE,
57+
pricing_plan_id=pricing_plan_id,
5958
)
6059
licensed_item_id = got.licensed_item_id
6160

@@ -121,6 +120,7 @@ async def test_licensed_items_db_trash(
121120
product_name=osparc_product_name,
122121
licensed_resource_name=name,
123122
licensed_resource_type=LicensedResourceType.VIP_MODEL,
123+
licensed_resource_data=VIP_DETAILS_EXAMPLE,
124124
pricing_plan_id=pricing_plan_id,
125125
)
126126
licensed_item_ids.append(licensed_item_db.licensed_item_id)

services/web/server/tests/unit/with_dbs/04/licenses/test_licensed_items_rest.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ async def test_licensed_items_listing(
5555
data, _ = await assert_status(resp, status.HTTP_200_OK)
5656
assert len(data) == 1
5757
assert LicensedItemRestGet(**data[0])
58+
assert data[0]["licensedResourceData"][
59+
"additionalField"
60+
] # <-- Testing nested camel case
61+
assert data[0]["licensedResourceData"]["features"][
62+
"additionalField"
63+
] # <-- Testing nested camel case
5864

5965
# get
6066
url = client.app.router["get_licensed_item"].url_for(

0 commit comments

Comments
 (0)