Skip to content

Commit cdbb141

Browse files
committed
refactor
1 parent ad64a17 commit cdbb141

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

services/static-webserver/client/source/class/osparc/jobs/Info.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,13 @@ qx.Class.define("osparc.jobs.Info", {
2424

2525
this._setLayout(new qx.ui.layout.VBox());
2626

27-
const htmlEmbed = osparc.wrapper.JsonFormatter.getInstance().createDiv();
27+
const divId = "job-info-viewer";
28+
const htmlEmbed = osparc.wrapper.JsonFormatter.getInstance().createContainer(divId);
2829
this._add(htmlEmbed, {
2930
flex: 1
3031
});
3132
this.addListener("appear", () => {
32-
osparc.wrapper.JsonFormatter.getInstance().setData(info);
33+
osparc.wrapper.JsonFormatter.getInstance().setData(info, divId);
3334
});
3435

3536
return;

services/static-webserver/client/source/class/osparc/wrapper/JsonFormatter.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,13 @@ qx.Class.define("osparc.wrapper.JsonFormatter", {
7878
});
7979
},
8080

81-
createDiv: function() {
82-
const htmlEmbed = new qx.ui.embed.Html("<div id='json-viewer'></div>");
83-
return htmlEmbed;
81+
createContainer: function(divId) {
82+
return new qx.ui.embed.Html("<div id='"+divId+"'></div>");
8483
},
8584

86-
setData: function(myJSON) {
85+
setData: function(myJSON, divId) {
8786
const formatter = new JSONFormatter(myJSON, 1); // 1 = expand depth
88-
document.getElementById("json-viewer").appendChild(formatter.render());
87+
document.getElementById(divId).appendChild(formatter.render());
8988
},
9089
}
9190
});

0 commit comments

Comments
 (0)