create

Author: pcrespov

api/specs/web-server/_tags.py

@@ -22,6 +22,7 @@
 @router.post(
     "/tags",
     response_model=Envelope[TagGet],
+    status_code=status.HTTP_201_CREATED,
 )
 async def create_tag(_body: TagCreate):
     ...

services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml

@@ -867,7 +867,7 @@ paths:
               $ref: '#/components/schemas/TagCreate'
         required: true
       responses:
-        '200':
+        '201':
           description: Successful Response
           content:
             application/json:

services/web/server/src/simcore_service_webserver/tags/_rest.py

@@ -64,7 +64,7 @@ async def create_tag(request: web.Request):
     created = await _service.create_tag(
         request.app, user_id=req_ctx.user_id, new_tag=new_tag
     )
-    return envelope_json_response(created)
+    return envelope_json_response(created, status_cls=web.HTTPCreated)
 
 
 @routes.get(f"/{VTAG}/tags", name="list_tags")

services/web/server/tests/unit/with_dbs/03/tags/test_tags.py

@@ -63,7 +63,7 @@ async def test_tags_to_studies(
     ]:
         url = client.app.router["create_tag"].url_for()
         resp = await client.post(f"{url}", json=tag)
-        added_tag, _ = await assert_status(resp, status.HTTP_200_OK)
+        added_tag, _ = await assert_status(resp, status.HTTP_201_CREATED)
         added_tags.append(added_tag)
 
         # Add tag to study
@@ -180,7 +180,7 @@ async def test_create_and_update_tags(
         f"{url}",
         json={"name": "T", "color": "#f00"},
     )
-    created, _ = await assert_status(resp, status.HTTP_200_OK)
+    created, _ = await assert_status(resp, status.HTTP_201_CREATED)
 
     assert created == {
         "id": created["id"],
@@ -234,7 +234,7 @@ async def test_create_tags_with_order_index(
                 "priority": priority_index,
             },
         )
-        created, _ = await assert_status(resp, status.HTTP_200_OK)
+        created, _ = await assert_status(resp, status.HTTP_201_CREATED)
         expected_tags[priority_index] = created
 
     url = client.app.router["list_tags"].url_for()
@@ -286,7 +286,7 @@ async def test_share_tags_by_creating_associated_groups(
         f"{url}",
         json={"name": "shared", "color": "#fff"},
     )
-    tag, _ = await assert_status(resp, status.HTTP_200_OK)
+    tag, _ = await assert_status(resp, status.HTTP_201_CREATED)
 
     # LIST
     url = client.app.router["list_tag_groups"].url_for(tag_id=f"{tag['id']}")
@@ -376,7 +376,7 @@ async def test_cannot_share_tag_with_everyone(
         f"{url}",
         json={"name": "shared", "color": "#fff"},
     )
-    tag, _ = await assert_status(resp, status.HTTP_200_OK)
+    tag, _ = await assert_status(resp, status.HTTP_201_CREATED)
     tag_id: int = tag["id"]
 
     # cannot SHARE with everyone group

services/web/server/tests/unit/with_dbs/04/workspaces/test_workspaces__list_projects_full_search.py

@@ -165,12 +165,11 @@ async def test_workspaces__list_projects_full_search(
     assert sorted_data[2]["folderId"] == root_folder["folderId"]
 
 
-@pytest.mark.parametrize("user_role,expected", [(UserRole.USER, status.HTTP_200_OK)])
+@pytest.mark.parametrize("user_role", [UserRole.USER])
 async def test__list_projects_full_search_with_query_parameters(
     client: TestClient,
     logged_user: UserInfoDict,
     user_project: ProjectDict,
-    expected: HTTPStatus,
     mock_catalog_api_get_services_for_user_in_product: MockerFixture,
     fake_project: ProjectDict,
     workspaces_clean_db: None,
@@ -220,14 +219,14 @@ async def test__list_projects_full_search_with_query_parameters(
     resp = await client.post(
         f"{url}", json={"name": "tag1", "description": "description1", "color": "#f00"}
     )
-    added_tag, _ = await assert_status(resp, expected)
+    added_tag, _ = await assert_status(resp, status.HTTP_201_CREATED)
 
     # Add tag to study
     url = client.app.router["add_project_tag"].url_for(
         project_uuid=project["uuid"], tag_id=str(added_tag.get("id"))
     )
     resp = await client.post(f"{url}")
-    data, _ = await assert_status(resp, expected)
+    data, _ = await assert_status(resp, status.HTTP_200_OK)
 
     # Full search with tag_ids
     base_url = client.app.router["list_projects_full_search"].url_for()