refactor: fix random_user call in insert_and_get_user_and_secrets_lifespan and update deprecation note in insert_user_and_secrets

pcrespov · pcrespov · commit ce00be13a89a · 2025-07-18T21:01:08.000+02:00
diff --git a/packages/pytest-simcore/src/pytest_simcore/helpers/postgres_users.py b/packages/pytest-simcore/src/pytest_simcore/helpers/postgres_users.py
@@ -32,7 +32,7 @@ async def insert_and_get_user_and_secrets_lifespan(
             insert_and_get_row_lifespan(  # pylint:disable=contextmanager-generator-missing-cleanup
                 sqlalchemy_async_engine,
                 table=users,
-                values=random_user(**random_user(**user_kwargs)),
+                values=random_user(**user_kwargs),
                 pk_col=users.c.id,
             )
         )
@@ -85,7 +85,7 @@ def sync_insert_and_get_user_and_secrets_lifespan(
 
 
 async def insert_user_and_secrets(conn, **overrides) -> int:
-    # NOTE: Legacy adapter. Use insert_and_get_user_and_secrets_lifespan instead
+    # NOTE: DEPRECATED: Legacy adapter. Use insert_and_get_user_and_secrets_lifespan instead
     # Temporarily used where conn is produce by aiopg_engine
 
     user_kwargs, secrets_kwargs = _get_kwargs_from_overrides(overrides)

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ async def insert_and_get_user_and_secrets_lifespan(`
`32`	`32`	`insert_and_get_row_lifespan( # pylint:disable=contextmanager-generator-missing-cleanup`
`33`	`33`	`sqlalchemy_async_engine,`
`34`	`34`	`table=users,`
`35`		`- values=random_user(random_user(user_kwargs)),`
	`35`	`+ values=random_user(**user_kwargs),`
`36`	`36`	`pk_col=users.c.id,`
`37`	`37`	`)`
`38`	`38`	`)`
`@@ -85,7 +85,7 @@ def sync_insert_and_get_user_and_secrets_lifespan(`
`85`	`85`
`86`	`86`
`87`	`87`	`async def insert_user_and_secrets(conn, **overrides) -> int:`
`88`		`- # NOTE: Legacy adapter. Use insert_and_get_user_and_secrets_lifespan instead`
	`88`	`+ # NOTE: DEPRECATED: Legacy adapter. Use insert_and_get_user_and_secrets_lifespan instead`
`89`	`89`	`# Temporarily used where conn is produce by aiopg_engine`
`90`	`90`
`91`	`91`	`user_kwargs, secrets_kwargs = _get_kwargs_from_overrides(overrides)`