Merge branch 'master' into fix/shared-with-everyone-filter

Author: odeimaiz

.github/PULL_REQUEST_TEMPLATE.md

@@ -10,6 +10,7 @@
   ⬆️    Upgrade dependencies.
   📝    Add or update documentation.
   🔨    Add or update development scripts.
+  ✅    Add, update or pass tests.
   🔒️    Fix security issues.
   ⚠️    Changes in ops configuration etc. are required before deploying.
         [ Please add a link to the associated ops-issue or PR, such as in https://github.com/ITISFoundation/osparc-ops-environments or https://git.speag.com/oSparc/osparc-infra ]
@@ -28,32 +29,16 @@ or from https://gitmoji.dev/
 
 
 ## Related issue/s
-
-<!-- Link pull request to an issue
-  SEE https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-
-- resolves ITISFoundation/osparc-issues#428
-- fixes #26
--->
+<!-- LINK to other issues and add prefix `closes`, `fixes`, `resolves`-->
 
 
 ## How to test
 
 <!-- Give REVIEWERS some hits or code snippets on how could this be tested -->
 
-## Dev-ops checklist
-
-- [ ] No ENV changes or I properly updated ENV ([read the instruction](https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/blob/configs/README.md?ref_type=heads#how-to-update-env-variables))
-
-<!-- Some checks that might help your code run stable on production, and help devops assess criticality.
-Modified from https://oschvr.com/posts/what-id-like-as-sre/
+## Dev-ops
 
-- How can DevOps check the health of the service ?
-- How can DevOps safely and gracefully restart the service ?
-- How and why would this code fail ?
-- What kind of metrics are you exposing ?
-- Is there any documentation/design specification for the service ?
-- How (e.g. through which loglines) can DevOps detect unexpected situations that require escalation to human ?
-- What are the resource limitations (CPU, RAM) expected for this service ?
-- Are all relevant variables documented and adjustable via environment variables (i.e. no hardcoded magic numbers) ?
+<!--
+- No changes /updated ENV. SEE https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/blob/configs/README.md?ref_type=heads#how-to-update-env-variables)
+- SEE docs/devops-checklist.md
 -->

.github/copilot-instructions.md

@@ -22,6 +22,7 @@ This document provides guidelines and best practices for using GitHub Copilot in
 - ensure we use `pydantic` >2 compatible code.
 - ensure we use `fastapi` >0.100 compatible code
 - use f-string formatting
+- Only add comments in function if strictly necessary
 
 
 ### Json serialization

.github/workflows/_reusable-build-images.yml

@@ -0,0 +1,61 @@
+name: Reusable Build Images
+
+on:
+  workflow_call:
+    inputs:
+      build-backend:
+        required: true
+        type: boolean
+        description: "Whether backend images should be built"
+      build-frontend:
+        required: true
+        type: boolean
+        description: "Whether frontend images should be built"
+      python-version:
+        required: true
+        type: string
+        description: "Python version to use"
+      os:
+        required: true
+        type: string
+        description: "Runner OS to use"
+
+jobs:
+  build-test-images:
+    timeout-minutes: 30
+    runs-on: ${{ inputs.os }}
+    steps:
+      - uses: actions/checkout@v4
+      - name: setup docker buildx
+        id: buildx
+        uses: docker/setup-buildx-action@v3
+        with:
+          driver: docker-container
+      - name: expose github runtime for buildx
+        uses: crazy-max/ghaction-github-runtime@v3
+      - name: show system environs
+        run: ./ci/helpers/show_system_versions.bash
+      - name: build backend images
+        if: ${{ inputs.build-backend }}
+        run: |
+          export DOCKER_IMAGE_TAG=$(exec ci/helpers/build_docker_image_tag.bash)
+          mkdir --parents /${{ runner.temp }}/build
+          make build local-dest=/${{ runner.temp }}/build exclude=static-webserver
+      - name: build frontend images
+        if: ${{ inputs.build-frontend }}
+        run: |
+          export DOCKER_IMAGE_TAG=$(exec ci/helpers/build_docker_image_tag.bash)
+          mkdir --parents /${{ runner.temp }}/build
+          make build local-dest=/${{ runner.temp }}/build target=static-webserver
+      - name: upload backend artifacts
+        if: ${{ inputs.build-backend }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: docker-buildx-images-${{ runner.os }}-${{ github.sha }}-backend
+          path: /${{ runner.temp }}/build
+      - name: upload frontend artifacts
+        if: ${{ inputs.build-frontend }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: docker-buildx-images-${{ runner.os }}-${{ github.sha }}-frontend
+          path: /${{ runner.temp }}/build

.github/workflows/ci-pact-master.yml

@@ -26,7 +26,7 @@ jobs:
         with:
           python-version: "3.11"
       - name: install uv
-        uses: astral-sh/setup-uv@v5
+        uses: astral-sh/setup-uv@v6
         with:
           version: "0.6.x"
           enable-cache: false