fixes

Author: matusdrobuliak66

services/docker-compose.yml

@@ -877,7 +877,7 @@ services:
       WEBSERVER_PORT: ${WB_API_WEBSERVER_PORT}
       WEBSERVER_RPC_NAMESPACE: ${WB_API_WEBSERVER_HOST}
       WEBSERVER_STATICWEB: "null"
-      WEBSERVER_CONVERSATIONS: "false" # override *webserver_environment
+      WEBSERVER_CONVERSATIONS: "null" # override *webserver_environment
       WEBSERVER_CHATBOT: "null" # override *webserver_environment
       WEBSERVER_FOGBUGZ: "null" # override *webserver_environment
 
@@ -922,7 +922,7 @@ services:
       WEBSERVER_ANNOUNCEMENTS: ${WB_DB_EL_ANNOUNCEMENTS}
       WEBSERVER_CATALOG: ${WB_DB_EL_CATALOG}
       WEBSERVER_CHATBOT: "null"
-      WEBSERVER_CONVERSATIONS: "false"
+      WEBSERVER_CONVERSATIONS: "null"
       WEBSERVER_CELERY: "null"
       WEBSERVER_DB_LISTENER: ${WB_DB_EL_DB_LISTENER}
       WEBSERVER_DIAGNOSTICS: ${WB_DB_EL_DIAGNOSTICS}
@@ -1005,7 +1005,7 @@ services:
       WEBSERVER_ANNOUNCEMENTS: ${WB_GC_ANNOUNCEMENTS}
       WEBSERVER_CATALOG: ${WB_GC_CATALOG}
       WEBSERVER_CHATBOT: "null"
-      WEBSERVER_CONVERSATIONS: "false"
+      WEBSERVER_CONVERSATIONS: "null"
       WEBSERVER_CELERY: "null"
       WEBSERVER_DB_LISTENER: ${WB_GC_DB_LISTENER}
       WEBSERVER_DIAGNOSTICS: ${WB_GC_DIAGNOSTICS}
@@ -1082,7 +1082,7 @@ services:
       WEBSERVER_ANNOUNCEMENTS: 0
       WEBSERVER_CATALOG: "null"
       WEBSERVER_CHATBOT: "null"
-      WEBSERVER_CONVERSATIONS: "false"
+      WEBSERVER_CONVERSATIONS: "null"
       WEBSERVER_CELERY: "null"
       WEBSERVER_DB_LISTENER: 0
       WEBSERVER_DIRECTOR_V2: "null"

services/web/server/src/simcore_service_webserver/chatbot/_process_chatbot_trigger_service.py

@@ -13,6 +13,7 @@
 from servicelib.rabbitmq import RabbitMQClient
 
 from ..conversations import conversations_service
+from ..conversations.errors import ConversationErrorNotFoundError
 from ..products import products_service
 from ..rabbitmq import get_rabbitmq_client
 from .chatbot_service import get_chatbot_rest_client
@@ -57,15 +58,21 @@ async def _process_chatbot_trigger_message(app: web.Application, data: bytes) ->
     chatbot_client = get_chatbot_rest_client(app)
     chat_response = await chatbot_client.ask_question(_question_for_chatbot)
 
-    await conversations_service.create_support_message(
-        app=app,
-        product_name=rabbit_message.conversation.product_name,
-        user_id=_product.support_chatbot_user_id,
-        conversation_user_type=ConversationUserType.CHATBOT_USER,
-        conversation=rabbit_message.conversation,
-        content=chat_response.answer,
-        type_=ConversationMessageType.MESSAGE,
-    )
+    try:
+        await conversations_service.create_support_message(
+            app=app,
+            product_name=rabbit_message.conversation.product_name,
+            user_id=_product.support_chatbot_user_id,
+            conversation_user_type=ConversationUserType.CHATBOT_USER,
+            conversation=rabbit_message.conversation,
+            content=chat_response.answer,
+            type_=ConversationMessageType.MESSAGE,
+        )
+    except ConversationErrorNotFoundError:
+        _logger.debug(
+            "Can not create a support message as conversation %s was not found",
+            rabbit_message.conversation.conversation_id,
+        )
     return True
 
 

services/web/server/src/simcore_service_webserver/conversations/_conversation_message_repository.py

@@ -24,7 +24,10 @@
 from sqlalchemy.sql import select
 
 from ..db.plugin import get_asyncpg_engine
-from .errors import ConversationMessageErrorNotFoundError
+from .errors import (
+    ConversationErrorNotFoundError,
+    ConversationMessageErrorNotFoundError,
+)
 
 _logger = logging.getLogger(__name__)
 
@@ -56,7 +59,10 @@ async def create(
             )
             .returning(*_SELECTION_ARGS)
         )
-        row = result.one()
+        row = result.one_or_none()
+        if row is None:
+            raise ConversationErrorNotFoundError(conversation_id=conversation_id)
+
         return ConversationMessageGetDB.model_validate(row)