Skip to content

Commit d01e3c3

Browse files
Merge branch 'master' into is5646/use-project-nodes-table-instead-of-workbench
2 parents 88c3159 + cebad23 commit d01e3c3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+1143
-586
lines changed

packages/pytest-simcore/src/pytest_simcore/simcore_services.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"whoami",
4141
"sto-worker",
4242
"sto-worker-cpu-bound",
43-
"traefik-configuration-placeholder",
43+
"traefik-config-placeholder",
4444
}
4545
# TODO: unify healthcheck policies see https://github.com/ITISFoundation/osparc-simcore/pull/2281
4646
DEFAULT_SERVICE_HEALTHCHECK_ENTRYPOINT: Final[str] = "/v0/"

services/api-server/src/simcore_service_api_server/api/routes/function_job_collections_routes.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import asyncio
21
from typing import Annotated, Final
32

43
from fastapi import APIRouter, Depends, status
@@ -14,19 +13,18 @@
1413
)
1514
from models_library.products import ProductName
1615
from models_library.users import UserID
16+
from servicelib.utils import limited_gather
1717
from simcore_service_api_server._service_function_jobs import FunctionJobService
18-
from simcore_service_api_server.api.dependencies.functions import (
19-
get_stored_job_status, # Import UserID
20-
)
21-
from simcore_service_api_server.api.dependencies.functions import (
22-
get_function_from_functionjobid,
23-
)
2418

2519
from ...models.pagination import Page, PaginationParams
2620
from ...models.schemas.errors import ErrorGet
2721
from ...services_http.director_v2 import DirectorV2Api
2822
from ...services_rpc.wb_api_server import WbApiRpcClient
2923
from ..dependencies.authentication import get_current_user_id, get_product_name
24+
from ..dependencies.functions import (
25+
get_function_from_functionjobid,
26+
get_stored_job_status,
27+
)
3028
from ..dependencies.models_schemas_function_filters import (
3129
get_function_job_collections_filters,
3230
)
@@ -269,7 +267,7 @@ async def function_job_collection_status(
269267
product_name=product_name,
270268
)
271269

272-
job_statuses = await asyncio.gather(
270+
job_statuses = await limited_gather(
273271
*[
274272
function_job_status(
275273
function_job=await get_function_job(
@@ -286,9 +284,9 @@ async def function_job_collection_status(
286284
),
287285
stored_job_status=await get_stored_job_status(
288286
function_job_id=function_job_id,
287+
wb_api_rpc=wb_api_rpc,
289288
user_id=user_id,
290289
product_name=product_name,
291-
wb_api_rpc=wb_api_rpc,
292290
),
293291
wb_api_rpc=wb_api_rpc,
294292
director2_api=director2_api,

services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,12 @@
2121
from models_library.projects_state import RunningState
2222
from models_library.users import UserID
2323
from servicelib.fastapi.dependencies import get_app
24-
from simcore_service_api_server._service_function_jobs import FunctionJobService
25-
from simcore_service_api_server.api.dependencies.functions import (
26-
get_function_from_functionjob,
27-
get_function_job_dependency,
28-
get_stored_job_outputs,
29-
get_stored_job_status,
30-
)
31-
from simcore_service_api_server.api.dependencies.models_schemas_function_filters import (
32-
get_function_jobs_filters,
33-
)
3424
from simcore_service_api_server.models.schemas.functions_filters import (
3525
FunctionJobsListFilters,
3626
)
3727
from sqlalchemy.ext.asyncio import AsyncEngine
3828

29+
from ..._service_function_jobs import FunctionJobService
3930
from ..._service_jobs import JobService
4031
from ...models.pagination import Page, PaginationParams
4132
from ...models.schemas.errors import ErrorGet
@@ -45,6 +36,13 @@
4536
from ...services_rpc.wb_api_server import WbApiRpcClient
4637
from ..dependencies.authentication import get_current_user_id, get_product_name
4738
from ..dependencies.database import get_db_asyncpg_engine
39+
from ..dependencies.functions import (
40+
get_function_from_functionjob,
41+
get_function_job_dependency,
42+
get_stored_job_outputs,
43+
get_stored_job_status,
44+
)
45+
from ..dependencies.models_schemas_function_filters import get_function_jobs_filters
4846
from ..dependencies.services import (
4947
get_api_client,
5048
get_function_job_service,

services/api-server/src/simcore_service_api_server/api/routes/functions_routes.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,10 @@
3636
from models_library.projects_state import RunningState
3737
from models_library.users import UserID
3838
from servicelib.fastapi.dependencies import get_reverse_url_mapper
39-
from simcore_service_api_server._service_function_jobs import FunctionJobService
40-
from simcore_service_api_server._service_functions import FunctionService
41-
from simcore_service_api_server._service_jobs import JobService
42-
from simcore_service_api_server.api.dependencies.functions import get_stored_job_status
4339

40+
from ..._service_function_jobs import FunctionJobService
41+
from ..._service_functions import FunctionService
42+
from ..._service_jobs import JobService
4443
from ..._service_solvers import SolverService
4544
from ...models.pagination import Page, PaginationParams
4645
from ...models.schemas.errors import ErrorGet
@@ -49,6 +48,7 @@
4948
from ...services_http.webserver import AuthSession
5049
from ...services_rpc.wb_api_server import WbApiRpcClient
5150
from ..dependencies.authentication import get_current_user_id, get_product_name
51+
from ..dependencies.functions import get_stored_job_status
5252
from ..dependencies.services import (
5353
get_api_client,
5454
get_function_job_service,

services/api-server/src/simcore_service_api_server/api/routes/studies_jobs.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@
6060
)
6161
from .solvers_jobs import JOBS_STATUS_CODES
6262

63-
# pylint: disable=too-many-arguments
64-
65-
6663
_logger = logging.getLogger(__name__)
6764

6865

services/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1550,7 +1550,7 @@ services:
15501550
#
15511551
# use fallback routes to return proper 503 (instead of 404)
15521552
# this service must be running at all times
1553-
traefik-configuration-placeholder:
1553+
traefik-config-placeholder:
15541554
image: busybox:1.35.0
15551555
command: sleep infinity
15561556
networks:

services/static-webserver/client/source/class/osparc/data/model/IframeHandler.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ qx.Class.define("osparc.data.model.IframeHandler", {
117117
}
118118

119119
const node = this.getNode();
120-
const thumbnail = node.getMetaData()["thumbnail"];
120+
const thumbnail = node.getMetadata()["thumbnail"];
121121
if (thumbnail) {
122122
loadingPage.setLogo(thumbnail);
123123
}
@@ -141,7 +141,7 @@ qx.Class.define("osparc.data.model.IframeHandler", {
141141
status = node.getStatus().getInteractive();
142142
}
143143
const statusText = status ? (status.charAt(0).toUpperCase() + status.slice(1)) : this.tr("Starting");
144-
const metadata = node.getMetaData();
144+
const metadata = node.getMetadata();
145145
const versionDisplay = osparc.service.Utils.extractVersionDisplay(metadata);
146146
return statusText + " " + node.getLabel() + " <span style='font-size: 16px;font-weight: normal;'><sub>v" + versionDisplay + "</sub></span>";
147147
},

0 commit comments

Comments
 (0)